Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: isolate server ut communication #5430

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

cisse21
Copy link
Member

@cisse21 cisse21 commented Jan 14, 2025

Description

< Replace with adequate description for this PR as per Pull Request document >

Linear Ticket

< Replace with Linear Link ( create or search linear ticket) or >

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@cisse21 cisse21 changed the title Feat.isolate server ut communication feat: isolate server ut communication Jan 14, 2025
@cisse21 cisse21 force-pushed the feat.isolateServerUTCommunication branch from 56c9769 to f16e30e Compare January 14, 2025 07:13
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 28.19149% with 675 lines in your changes missing coverage. Please review.

Project coverage is 74.01%. Comparing base (aaae529) to head (5c1c564).

Files with missing lines Patch % Lines
...ssor/internal/user_transformer/user_transformer.go 6.35% 221 Missing ⚠️
...trackingplan_validation/trackingplan_validation.go 6.33% 207 Missing ⚠️
...destination_transformer/destination_transformer.go 6.69% 195 Missing ⚠️
processor/internal/http_client/http_client.go 44.73% 21 Missing ⚠️
...or/internal/transformer_utils/transformer_utils.go 0.00% 17 Missing ⚠️
processor/processor.go 94.91% 5 Missing and 1 partial ⚠️
processor/transformer/manager.go 50.00% 6 Missing ⚠️
processor/trackingplan.go 92.85% 1 Missing ⚠️
...ger/transformation/transformationStatusUploader.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5430      +/-   ##
==========================================
- Coverage   74.79%   74.01%   -0.78%     
==========================================
  Files         440      447       +7     
  Lines       61670    62406     +736     
==========================================
+ Hits        46125    46191      +66     
- Misses      13002    13673     +671     
+ Partials     2543     2542       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cisse21 cisse21 force-pushed the feat.isolateServerUTCommunication branch from b31ee2d to 1771a8e Compare January 15, 2025 04:47
@cisse21 cisse21 force-pushed the feat.isolateServerUTCommunication branch from e471d37 to abd8358 Compare January 15, 2025 08:56
@cisse21 cisse21 force-pushed the feat.isolateServerUTCommunication branch from 09ad557 to 4bf68a2 Compare January 20, 2025 09:57
Copy link
Contributor

@ktgowtham ktgowtham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Can I assume the implementation logic(in user_trans, dest_trans) is exactly same as copied from transformer.go? planning to skip reviewing that part for just skim it through.

  2. router transformer will remain as is? it’s only transformation in processor that we’re splitting out rt?

  3. Looks like we’ve not replaced function calls to use the new sendrequest function. do we plan to do that in follow up PR?

  4. Are we okay to have types.TransformerEvent as param for all implementations(in ServiceClient -> SendRequest)? Will we lose flexibility to have same struct? or is it going to be same and we choose what to populate in that struct?

@cisse21
Copy link
Member Author

cisse21 commented Jan 22, 2025

Can I assume the implementation logic(in user_trans, dest_trans) is exactly same as copied from transformer.go? planning to skip reviewing that part for just skim it through.

Yeah... I just got rid of a few things here and there which are relevant to individual components but yeah in this PR we can assume that it is going to be the same

router transformer will remain as is? it’s only transformation in processor that we’re splitting out rt?

Yes... it is only the processor transformer module we are splitting out

Looks like we’ve not replaced function calls to use the new sendrequest function. do we plan to do that in follow up PR?

That is the only part remaining where I will put it under a flag so that we can switch between older and newer implementation

Are we okay to have types.TransformerEvent as param for all implementations(in ServiceClient -> SendRequest)? Will we lose flexibility to have same struct? or is it going to be same and we choose what to populate in that struct?

Didn't want to make too many changes in one PR but the idea is to abstract out things in this PR and then change the structs with the appropriate data over the subsequent PR's

@ktgowtham ktgowtham self-requested a review January 22, 2025 08:54
endlessBackoff.MaxInterval = t.config.maxRetryBackoffInterval.Load()

// endless backoff loop, only nil error or panics inside
_ = backoff.RetryNotify(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider dropping endless backoff here too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed from what I discussed with @Jayachand

@cisse21 cisse21 force-pushed the feat.isolateServerUTCommunication branch from 5c1c564 to f01fe43 Compare January 22, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants