Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): add dockerhub publish CI action #35 #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

garciagenrique
Copy link
Contributor

@garciagenrique garciagenrique commented Feb 14, 2025

Solves #35

This PR builds a docker image of the repository and publish it to dockerHub.

Ci works fine - tested on a branch of my fork. See also the CI action output and the published image on dockerhub/garciagenrique.

Few points to discuss/TODO:

  • @bari12 we would need to add the rucio docker hub credentials on as secrets of this repo. Could you add them, please?
     - name: Log into the Docker Hub
       id: login
       uses: docker/login-action@v3
       with:
         username: ${{ secrets.DOCKER_USERNAME }}
         password: ${{ secrets.DOCKER_PASSWORD }}
  • Image will be only published when a new version of the repository is created. Do we want to push images on every merge to master ? I would say yes. In case we publish the images on merges, which tag should we use for the image ? :latest ? :sha-<SHORT_SHA> ? both ?

@rdimaio
Copy link

rdimaio commented Feb 14, 2025

* [ ]  @bari12 we would need to add the rucio docker hub credentials on as secrets of this repo. Could you add them, please?

To avoid having to duplicate them, they can also be set as organization secrets and made only accessible to the appropriate repos (containers and jupyterlab-extension): https://docs.github.com/en/codespaces/managing-codespaces-for-your-organization/managing-development-environment-secrets-for-your-repository-or-organization#adding-secrets-for-an-organization

@ftorradeflot
Copy link
Contributor

  • Image will be only published when a new version of the repository is created. Do we want to push images on every merge to master ? I would say yes. In case we publish the images on merges, which tag should we use for the image ? :latest ? :sha-<SHORT_SHA> ? both ?

Although the master branch should be stable I wouldn't push to latest if it has not been tagged. I propose pushing to :master always and also to :latest and :{tag} when tagged

@garciagenrique
Copy link
Contributor Author

Although the master branch should be stable I wouldn't push to latest if it has not been tagged. I propose pushing to :master always and also to :latest and :{tag} when tagged

Done @ftorradeflot, thanks for the suggestion !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants