Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a configurable connection open timeout #387

Merged
merged 4 commits into from
Jun 2, 2024

Conversation

robbkidd
Copy link

@robbkidd robbkidd commented Jun 1, 2024

Description:


Tasks:

  • Add :open_timeout to config options
    • Include Gemstash::Env::Helper in HTTPClient to make gemstash_env available as an instance method
    • Use gemstash_env to lookup new config option value when making requests
  • Update docs
    • Add :open_timeout to docs and describe why someone would want to change it
    • Rephrase :fetch_timeout to make clear that it is the time for the entire open-receive-read process to complete
  • Write tests
    • I do not currently know a way to test the socket open timeout in the test suite. I am open to guidance because I would love to.

✅ I will abide by the code of conduct. 💞

@indirect indirect force-pushed the configurable-connect-timeout branch from d2ee2cc to 42475a1 Compare June 2, 2024 05:31
@indirect indirect merged commit f7c6799 into rubygems:main Jun 2, 2024
5 checks passed
@robbkidd
Copy link
Author

robbkidd commented Jun 3, 2024

❯ git show
commit d2ee2ccc7ef5b48e927aaeca236deb29395f4ad8
Author: Robb Kidd <[email protected]> # lolwut?
…

❯ git config user.email
[email protected]

🤦🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hard-coded short open timeout hurts when pull-through caching on high-latency ISP
2 participants