Gemfile: use middleman/middleman from git #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The desired Pull Request has been merged. I added a comment about a HAML 6-supporting change, as well. Perhaps we can begin using HAML 6, soon.
tnir
reviewed
Sep 27, 2022
There was a problem hiding this comment.
Makes sense to me: tnir/middleman@80f9122...038f4f6
Updates #901
|
Thanks for weighing in, @tnir, there's a lot of movement in these ancient repositories (haml, middleman!) just these days. |
While I already found we cannot use HAML 6 yet before I have created #918, I am sorry that I did not describe why we cannot on #918. Just updated the description of #918, @olleolleolle. |
|
I forgot I have made a naive patch available at middleman/middleman-syntax#80 last month 👀 , but I could not feel like creating a PR in the upstream... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was that tnir's branch has been merged to the middleman/middleman repo, and it's perhaps more legible to refer to that repository.
What was your diagnosis of the problem?
My diagnosis was that it would be easier to understand if we referred to the middleman/middleman repo instead of tnir's, now that the PR is merged.
What is your fix for the problem, implemented in this PR?
My fix is to use the source repo, not the forked one, in our Gemfile.
Why did you choose this fix out of the possible options?
N/A.