Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump bootstrap from 5.1.3 to 5.3.3 #1302

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 26, 2024

Bumps bootstrap from 5.1.3 to 5.3.3.

Release notes

Sourced from bootstrap's releases.

v5.3.3

Highlights

  • Fixed a breaking change introduced with color modes where it was required to manually import variables-dark.scss when building Bootstrap with Sass. Now, _variables.scss will automatically import _variables-dark.scss. If you were already importing _variables-dark.scss manually, you should keep doing it as it won't break anything and will be the way to go in v6.
  • Fixed a regression in the selector engine that wasn't able to handle multiple IDs anymore.

Color modes

  • Badges now use the .text-bg-* text utilities to be certain that the text is always readable (especially when the customized colors are different in light and dark modes).
  • Fixed our color-modes.js script to handle the case where the OS is set to light mode and the auto color mode is used on the website. If you copied the script from our docs, you should apply this change to your own script.
  • Fixed color schemes description in the color modes documentation to show that color-scheme() only accept light and dark values as parameters.

Miscellaneous

  • Allowed <dl>, <dt> and <dd> in the sanitizer.
  • Dropped evenly items distribution for modal and offcanvas headers.
  • Fixed the accordion CSS selectors to avoid inheritance issues when nesting accordions.
  • Fixed the focus box-shadow for the validation stated form controls.
  • Fixed the focus ring on focused checked buttons.
  • Fixed the product example mobile navbar toggler.
  • Changed the RTL processing of carousel control icons.

🎨 CSS

  • #37508: Use child combinators to avoid inheriting parent accordion's flush styles
  • #38719: Fix focus box-shadow for validation stated form-controls
  • #38884: fix border-radius on radio-switch
  • #39294: Tests: update navbar in visual modal test
  • #39373: refactor css: modal and offcanvas header spacing
  • #39380: Fix Sass compilation breaking change in v5.3
  • #39387: docs: fix typo
  • #39411: Optimize the accordion icon
  • #39497: Fix a typo
  • #39536: Changed RTL processing of carousel control icons
  • #39560: Drop --bs-accordion-btn-focus-border-color and deprecate $accordion-button-focus-border-color
  • #39595: CSS: Fix the focus ring on focused checked buttons

☕️ JavaScript

  • #39201: Selector Engine: fix multiple IDs
  • #39224: Fix edge case in color-mode.js
  • #39376: Allow dl, dt and dd in sanitizer

📖 Docs

  • #39200: Typo Fix
  • #39214: Doc: use .text-bg-{color} for all badges
  • #39246: Docs: fix for example code blocks have unnecessary 30px right-margin

... (truncated)

Commits
  • 6e1f75f Release v5.3.3 (#39524)
  • 3caef2b Build(deps-dev): Bump terser from 5.27.1 to 5.27.2 (#39690)
  • 4abac9b Build(deps-dev): Bump ip from 2.0.0 to 2.0.1 (#39691)
  • c396a2a Build(deps-dev): Bump sass from 1.70.0 to 1.71.0 (#39684)
  • c9a8a40 Build(deps-dev): Bump rollup from 4.9.6 to 4.12.0 (#39683)
  • 6aecb37 Build(deps-dev): Bump eslint-plugin-html from 7.1.0 to 8.0.0 (#39672)
  • 4081168 Build(deps-dev): Bump terser from 5.27.0 to 5.27.1 (#39682)
  • 4605d71 Build(deps-dev): Bump postcss from 8.4.34 to 8.4.35 (#39673)
  • 08eeee3 Build(deps-dev): Bump lockfile-lint from 4.12.1 to 4.13.1 (#39675)
  • f92d635 Build(deps-dev): Bump eslint-plugin-unicorn from 51.0.0 to 51.0.1 (#39676)
  • Additional commits viewable in compare view

Most Recent Ignore Conditions Applied to This Pull Request
Dependency Name Ignore Conditions
bootstrap [>= 5.2.a, < 5.3]

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Feb 26, 2024
@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-dependabot-kymhab February 26, 2024 08:53 Inactive
@deivid-rodriguez deivid-rodriguez force-pushed the dependabot/npm_and_yarn/bootstrap-5.3.3 branch 3 times, most recently from 3b30820 to a9fc8d8 Compare December 20, 2024 19:28
@deivid-rodriguez
Copy link
Member

I got bootstrap 5.3.3 working as well. This is built on top of #729.

@olleolleolle
Copy link
Member

@deivid-rodriguez That's fabulous news! Want to take the plunge ahead?

deivid-rodriguez and others added 2 commits December 27, 2024 20:09
getInstance should always return an instance.
The search tooltip had strange behavior related to hovering.
I found a hack to disable that behavior.

Bumps [bootstrap](https://github.com/twbs/bootstrap) from 5.2.0 to 5.3.3.
- [Release notes](https://github.com/twbs/bootstrap/releases)
- [Commits](twbs/bootstrap@v5.2.0...v5.3.3)

---
updated-dependencies:
- dependency-name: bootstrap
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@deivid-rodriguez deivid-rodriguez force-pushed the dependabot/npm_and_yarn/bootstrap-5.3.3 branch from a9fc8d8 to e9310a4 Compare December 27, 2024 19:10
@deivid-rodriguez
Copy link
Member

@olleolleolle For some reason I missed your last comment, sorry! I merged #729 for now and I just rebased this one. I just noticed though that I believe search box fonts now look smaller than before? Do you have the same impression? Happy to look into it more and try to restore the previous appearance before moving forward with this upgrade.

@deivid-rodriguez
Copy link
Member

Actually, it seems this was just my impression but I rebuilt the site locally with the previous dependencies and could not find any differences. So I'll merge this PR as well.

@deivid-rodriguez deivid-rodriguez merged commit 915c78b into master Dec 30, 2024
3 checks passed
@deivid-rodriguez deivid-rodriguez deleted the dependabot/npm_and_yarn/bootstrap-5.3.3 branch December 30, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants