Avoid using hashrocket for a kwarg in a migration file #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hashrocket here will be treated as a Hash object literal rather than
a kwarg under recent versions of Ruby, and this will end up with
creating broken schema.rb with the following diff via db:migrate
- t.string "item_type", null: false
+ t.string "item_type"
+ t.string "{:null=>false}"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch manually edits a broken migration file introduced via a991671.
Since the hashrocket here will be treated as a Hash object literal rather than a kwarg under recent versions of Ruby, which will end up with creating broken schema.rb with the following diff via
db:migrate.