feat: create an EC::PKey from an EC::Point #916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhenium
requested changes
Jul 27, 2025
| @@ -125,7 +159,7 @@ ossl_ec_key_s_generate(VALUE klass, VALUE arg) | |||
| /* | |||
| * call-seq: | |||
| * OpenSSL::PKey::EC.new | |||
| * OpenSSL::PKey::EC.new(ec_key) | |||
| * OpenSSL::PKey::EC.new(ec_key) # ec_key is PKey::EC, or PKey::EC::Point. | |||
There was a problem hiding this comment.
Suggested change
| * OpenSSL::PKey::EC.new(ec_key) # ec_key is PKey::EC, or PKey::EC::Point. | |
| * OpenSSL::PKey::EC.new(ec_key) | |
| * OpenSSL::PKey::EC.new(ec_point) |
| { | ||
| EC_KEY *ec = NULL; | ||
|
|
||
| if (rb_obj_is_kind_of(arg, cEC_POINT)) { |
| ossl_raise(eECError, NULL); | ||
| } | ||
|
|
||
| GetECPoint(arg, point); |
There was a problem hiding this comment.
GetECPoint() and GetECPointGroup() should be called before ec is allocated. They can potentially raise an exception, and in that case ec could leak.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is implied that OpenSSL::PKey::EC.new can take a public key/EC::Point to form a key, but I could not make it work.
Since 3.x wants keys immutable, they have to be initialized at creation, and this allows for an EC::Point to be provided.
RSA keys do not have the same division between PKey and Point.