Merged
Conversation
Contributor
|
@lsouoliveira thanks for this. Can you update this branch? You will need to upgrade ruby_ui and generate sidebar components again (you can erase the app/components/ruby_ui/sidebar folder before running the generator again). |
lsouoliveira
force-pushed
the
add-sidebar-component
branch
3 times, most recently
from
c0ed25a to
ad242bd
Compare
lsouoliveira
force-pushed
the
add-sidebar-component
branch
from
ad242bd to
1892c17
Compare
Member
|
Hey! This looks great! |
Member
|
Hey do you have X, or discord where i can message you @lsouoliveira? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the sidebar component to the docs. It also updates the
VisualCodeExamplecomponent to support iframes as a method of presenting components.Screen captures