Fix: I18n.locale reset in Fiber context by using Thread#thread_variable #724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le_{get,set}
- Change I18n.config storage from Thread.current[:i18n_config] to
Thread.current.thread_variable_get/set, which is inherited by Fibers
- Update I18n.config= and middleware to use thread_variable_set
- Update tests to verify I18n.locale preservation in Fiber context
lee266
changed the title
lee266
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #723
Summary
This PR fixes an issue where I18n.locale is unexpectedly reset when entering a new Fiber context.
Currently, I18n stores its configuration with Thread.current[:i18n_config].
However, in Ruby, Thread.current[:key] is fiber-local, not strictly thread-local.
As a result, each Fiber gets its own isolated config, and I18n.locale falls back to default_locale inside new Fibers.
Fix
Switch to Thread#thread_variable_get/set, which provides true thread-local storage and is inherited by Fibers.