Introduce support for deprecating translation keys #490
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was born out of the discussion on solidusio/solidus_auth_devise#173. It was originally started by @kennyadsl and completed by me.
The rationale and logic are explained in the commit message for future reference.
Please note that it's very experimental and we understand it may be too complex and/or opinionated to be introduced into I18n directly. We're happy to accept any change requests or even to make it a separate gem if you feel like I18n is not a good place for it.
It's still a bit rough at the edges. If this sparks enough interest, we'd like to:
translatepatches toDeprecator. This would be much cleaner, but it has some performance drawbacks, mainly that we'd need to calllookupinDeprecatorjust to check if the keys are defined, but then still delegate tosuperfor the rest of the logic, andsuperwould calllookupagain.Hopefully, the current state of it is enough for you to get an idea!