Fix error in Gem version comparison

[diko4096]

Gem::Version can be compared with another Gem::Version, not with string. It were caused crash on the boot time:

/srv/endpoints/vendor/ruby/3.0.0/gems/kicks-3.1.1/lib/active_job/queue_adapters/sneakers_adapter.rb:2:in >': comparison of Gem::Version with String failed (ArgumentError)
from /srv/endpoints/vendor/ruby/3.0.0/gems/kicks-3.1.1/lib/active_job/queue_adapters/sneakers_adapter.rb:2:in <top (required)>' from /srv/endpoints/vendor/ruby/3.0.0/gems/activesupport-6.1.4/lib/active_support/dependencies.rb:332:in require'
from /srv/endpoints/vendor/ruby/3.0.0/gems/activesupport-6.1.4/lib/active_support/dependencies.rb:332:in block in require' from /srv/endpoints/vendor/ruby/3.0.0/gems/activesupport-6.1.4/lib/active_support/dependencies.rb:299:in load_dependency'
from /srv/endpoints/vendor/ruby/3.0.0/gems/activesupport-6.1.4/lib/active_support/dependencies.rb:332:in require' from /srv/endpoints/vendor/ruby/3.0.0/gems/kicks-3.1.1/lib/sneakers.rb:25:in <top (required)>'
from /srv/endpoints/vendor/ruby/3.0.0/gems/activesupport-6.1.4/lib/active_support/dependencies.rb:332:in require' ...

[simi]

Can you check this is fixed by upgrading to later RubyGems? rubygems/rubygems@7e0dbb7 Seems RubyGems 3.4+ are ok with this. Happy to merge this, I just want to ensure I do follow what's happening.

[diko4096]

Can you check this is fixed by upgrading to later RubyGems? rubygems/rubygems@7e0dbb7 Seems RubyGems 3.4+ are ok with this. Happy to merge this, I just want to ensure I do follow what's happening.

Unfortunately I cant, because I maintain the legacy project, and needed to update only bunny to the latest version. Because there are sneakers used, and it abandoned, I've decided to switch to the kicks in the current environment. I suppose my fix doesn't broke anything, but increase compatibility with former rubygems.

[simi]

Can you check this is fixed by upgrading to later RubyGems? rubygems/rubygems@7e0dbb7 Seems RubyGems 3.4+ are ok with this. Happy to merge this, I just want to ensure I do follow what's happening.

Unfortunately I cant, because I maintain the legacy project, and needed to update only bunny to the latest version. Because there are sneakers used, and it abandoned, I've decided to switch to the kicks in the current environment. I suppose my fix doesn't broke anything, but increase compatibility with former rubygems.

Can you at least check what's your RubyGems version?

[michaelklishin]

@diko4096 fair enough, this should work perfectly fine with recent RubyGems but I second @simi's question about what RubyGems version you run.

[diko4096]

@michaelklishin rubygems version 3.2.22 (in my legacy project) has that issue, but I've checked it with 3.5.23 and there it works fine. My request just for backward compatibility. Thanks a lot.

[texpert]

Hmm, I'm late to the party, but the right way to check for a constant being defined is:

Object.const_defined? "ActiveJob", because defined?(FOO) # => "constant"

[michaelklishin]

@texpert you are welcome to submit a PR but defined?(SomethingNonExistent) returns nil which evaluates to false, so there is no practical difference. The readability of both is very comparable, too.

[texpert]

Hm, yes, @michaelklishin , you're right, sorry for the noise!