Load ActiveJob adapter only for rails >= 7.2
#19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails introduced `ActiveJob::QueueAdapters::AbstratAdapter` in 7.2 version. So this PR conditionally loads "in-house" adapter only if `activejob` version is >= 7.2. If version is less than 7.2 adapter implemented inside the rails will be used.
|
I think this can and should go into |
dixpac
commented
Oct 30, 2024
| module ActiveJob | ||
| module QueueAdapters | ||
| # Explicitly remove the implementation existing in older Rails versions'. | ||
| remove_const(:SneakersAdapter) if defined?("::#{name}::SneakersAdapter") |
There was a problem hiding this comment.
Slight change here also:
When Ruby parses the expression
defined?(:ANY_SYMBOL)
it recognizes the symbol :ANY_SYMBOL and adds it to its list of known symbols. It will always be truthy.
What we really want is
module ActiveJob
module QueueAdapters
remove_const(:SneakersAdapter) if defined?("::#{name}::SneakersAdapter")
There was a problem hiding this comment.
The comment communicates the general idea. You are welcome to add a more detailed comment if you see the need.
|
@dixpac thank you. If we agree that it can go into |
|
@michaelklishin I can cut new release today if welcomed. |
|
@simi no objections from me. Just remember to update the change log before tagging. |
michaelklishin
pushed a commit
that referenced
this pull request
Nov 1, 2024
Rails introduced `ActiveJob::QueueAdapters::AbstratAdapter` in 7.2 version. So this PR conditionally loads "in-house" adapter only if `activejob` version is >= 7.2. If version is less than 7.2 adapter implemented inside the rails will be used. (cherry picked from commit aeafaba)
michaelklishin
added a commit
that referenced
this pull request
Nov 1, 2024
|
Shipped in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails introduced
ActiveJob::QueueAdapters::AbstratAdapterin 7.2 version.So this PR conditionally loads "in-house" adapter only if
activejobversion is >= 7.2. If version is less than 7.2 adapter implemented inside the rails will be used.