Logging: remove redundant Hutch::Config.initialize #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to do some more testing with various Hutch CLI scenarios before we can be confident that it's no longer needed. |
|
Still needs some testing on my end. I likely won't have the time to do it next week, sorry. |
|
@michaelklishin I'm not in a rush to have this land. I logged #261 as a follow-up issue for this when I found it. It's a hen-and-egg of Config defaults and settings. (Colloquially described: The logger wants a level before a level has been resolved to a real setting value.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last statement of the Config class is to run initialize. We don't need to do it twice.