Make the RuboCop::Minitest::Test suite re-usable by gem consumers

[DougEdey]

I've been writing custom cops for various jobs for a while now, but I've never had a consistent way to write tests for products that use minitest as the test suite (officially Rubocop only provides rspec helpers) , I started to look around to see what this Gem did and figured it would make sense to make rubocop-minitest provide a minitest class for others that write custom cops for their own code bases.

This does a couple of things

1. Makes a new Rubocop::Minitest::Test class that includes the code from assert_offense (I don't feel like it needs to be a module), and it also uses declarative testing for people to use.
2. I moved the "real" test suites in this gem to use the new base class, and kept the code blocks being tested as Minitest::Test
3. I added declarative testing since all the test suites I've been in have it, where instead of using def test_something_does_something...end you can do test "something does something" do...end which makes it easier to read test names.

I tested this locally in an app of mine and it works great! So it can allow a consistent way for people to write custom cops and easily test them!

---

Before submitting the PR make sure the following are checked:

• The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
• Wrote good commit messages.
• [-] Commit message starts with [Fix #issue-number] (if the related issue exists).
• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
• Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

[exterm]

This makes a lot of sense to me and I'd love to use it.

[Earlopain]

If this is being exposed like this then I think it needs some documetation on how to pass global and cop specific config to a test.

See

rubocop-minitest/test/rubocop/cop/minitest/global_expectations_test.rb

Lines 504 to 513 in b446022

	def configure_enforced_style(style)
	all_config = RuboCop::Minitest::CONFIG
	cop_config = all_config['Minitest/GlobalExpectations']
	cop_config = cop_config.merge('EnforcedStyle' => style)
	all_config = all_config.merge('Minitest/GlobalExpectations' => cop_config)
	config = RuboCop::Config.new(all_config)
	@cop = RuboCop::Cop::Minitest::GlobalExpectations.new(config)
	@preferred_method = style == :any ? :_ : style
	end
	end

and

rubocop-minitest/test/rubocop/cop/minitest/multiple_assertions_test.rb

Lines 339 to 343 in b446022

	def configure_max_assertions(max)
	cop_config = RuboCop::Config.new('Minitest/MultipleAssertions' => { 'Max' => max })
	@cop = RuboCop::Cop::Minitest::MultipleAssertions.new(cop_config)
	end
	end

[DougEdey]

@Earlopain Updated the casing of RuboCop, updated the sample docs (both inline and README.md), handling the nil case for @cop

[DougEdey]

Squashed commits and confirmed CI is passing locally

[DougEdey]

@koic 👋 Could I ask for a review?

[DougEdey]

@koic it's been a while, but I'd still like to get this merged

[Earlopain]

It's been a while since I last looked at this and this may be a dumb question to only come now but can you explain why this is needed?

Specifically I think there already exists what you are looking for: #155 and #156

https://github.com/rubocop/rubocop-minitest/blob/master/lib/rubocop/minitest/support.rb
There may be concern about it polluting the main test class but even then you can just make your own and mix that module in yourself.