Support Scala 3 (by dropping madgag-compress for zip4j?)
#18
+21
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtyley-scala-library-release bot
added a commit
that referenced
this pull request
Aug 18, 2025
…rtyley rtyley published release version 7.0.0-PREVIEW.support-scala-3.2025-08-18T0747.e34aa011 using gha-scala-library-release-workflow: https://github.com/guardian/gha-scala-library-release-workflow Release-Version: 7.0.0-PREVIEW.support-scala-3.2025-08-18T0747.e34aa011 Release-Initiated-By: https://github.com/rtyley Release-Workflow-Run: https://github.com/rtyley/scala-git/actions/runs/17034395740 Release-Notes: #18
|
@rtyley has published a preview version of this PR with release workflow run #10, based on commit e34aa01: 7.0.0-PREVIEW.support-scala-3.2025-08-18T0747.e34aa011 Want to make another preview release?Click 'Run workflow' in the GitHub UI, specifying the support-scala-3 branch, or use the GitHub CLI command: gh workflow run release.yml --ref support-scala-3 Want to make a full release after this PR is merged?Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command: gh workflow run release.yml |
rtyley
force-pushed
the
support-scala-3
branch
from
e34aa01 to
50e8268
Compare
# Conflicts: # version.sbt
rtyley
force-pushed
the
support-scala-3
branch
from
50e8268 to
5fbc475
Compare
rtyley
changed the title
madgag-compress for zip4j
rtyley
changed the title
madgag-compress for zip4jmadgag-compress for zip4j)
rtyley
commented
Aug 18, 2025
| @@ -6,7 +6,7 @@ object Dependencies { | |||
|
|
|||
| val scalatest = "org.scalatest" %% "scalatest" % "3.2.19" | |||
|
|
|||
| val madgagCompress = "com.madgag" % "util-compress" % "1.35" | |||
There was a problem hiding this comment.
This artifact is old - from October 2017. Is there something about this artifact in particular that's the problem?
rtyley
changed the title
madgag-compress for zip4j)madgag-compress for zip4j?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Scala 3 upgrade seems to overcome the problems found in this prior Scala-3-upgrade PR:
ClassLoaderLayeringStrategy?) #14