Skip to content

Fiducials not working correctly #96

Open

Description

@tvalimaki

The raytracing step for fiducial detection scans as far as the maximum range, therefore fiducials that have an obstacle behind them, in range of the sensor, won't be detected. There's a TODO note in the code reflecting this (line 180 in model_fiducial.cc). Is there some reason the max_range_anon couldn't just be replaced with range, which is the distance to the fiducial?

I tested this and it seems to fix the issue. I'm more than happy to create a pull request if this is all that is needed and it doesn't break anything.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions