Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chd: Fix various memory and overflow bugs #132

Merged
merged 13 commits into from
Nov 10, 2024
Merged

chd: Fix various memory and overflow bugs #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
96bdd36
chd: Fix potential buffer overread in compressed data
stenzek Oct 25, 2024
ebff5e7
chd: Avoid multiplication overflow in map_size_v5()
stenzek Oct 25, 2024
a154073
chd: Fix potential buffer overflow in huffman_build_lookup_table()
stenzek Oct 25, 2024
c1ed679
chd: Fix possible divide by zero in chd_get_metadata()
stenzek Oct 25, 2024
5572ace
chd: Fix potential OOM in decompress_v5_map()
stenzek Oct 25, 2024
45670a9
chd: Don't try to initialize the same codec twice
stenzek Oct 25, 2024
2747640
chd: Stop reading rawmap if EOF reached
stenzek Oct 25, 2024
62e41f3
chd: Store overall file size and bounds check precached reads
stenzek Oct 25, 2024
6259d92
chd: Fix potential buffer overread in hunk_read_compressed()
stenzek Oct 25, 2024
bc0690b
chd: Fix potential memory leak in huffman_import_tree_huffman()
stenzek Oct 25, 2024
b2e05f5
chd: Enforce some basic size limits in header_validate()
stenzek Oct 25, 2024
70cfcbe
cmake: Add libfuzzer harness and target
stenzek Oct 25, 2024
09fa975
chd: Check that metadata seek succeeds
stenzek Nov 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,14 @@ if(BUILD_LTO)
endif()
endif()

option(BUILD_FUZZER "Build instrumented binary for fuzzing with libfuzzer, requires clang")
if(BUILD_FUZZER)
# Override CFLAGS early for instrumentation. Disable shared libs for instrumentation.
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fsanitize=address,fuzzer-no-link")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=address,fuzzer-no-link")
set(BUILD_SHARED_LIBS OFF)
endif()

include(GNUInstallDirs)

#--------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion include/libchdr/huffman.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,6 @@ int huffman_build_tree(struct huffman_decoder* decoder, uint32_t totaldata, uint
enum huffman_error huffman_assign_canonical_codes(struct huffman_decoder* decoder);
enum huffman_error huffman_compute_tree_from_histo(struct huffman_decoder* decoder);

void huffman_build_lookup_table(struct huffman_decoder* decoder);
enum huffman_error huffman_build_lookup_table(struct huffman_decoder* decoder);

#endif
Loading