Add a way to look up where the elm binaries are #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we should use this in |
|
Yeah I thought we did already but I was wrong |
eeue56
commented
Jan 22, 2018
| module.exports = { | ||
| compile: compile, | ||
| compileSync: compileSync, | ||
| compileWorker: require("./worker.js")(compile), | ||
| compileToString: compileToString, | ||
| compileToStringSync: compileToStringSync, | ||
| findAllDependencies: findAllDependencies | ||
| findAllDependencies: findAllDependencies, | ||
| findElmBinaries: findElmBinaries |
There was a problem hiding this comment.
Maybe this name is bad?
There was a problem hiding this comment.
how about preferedElmBinaries or elmBinariesLocation?
There was a problem hiding this comment.
Yeah, based on the name I'd be surprised to learn this was searching node_modules first... 🤔
That said, I haven't thought of a better one. 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is used in a few projects, like:
Likewise, it should probably be used in elm-webpack-loader and similar tools, since generally the expected behaviour for these tools is to use the locally installed (node_modules) over the global