Skip to content

Commit

Permalink
Remove iife
Browse files Browse the repository at this point in the history
  • Loading branch information
FrancoisGuillem committed Aug 17, 2017
1 parent 0a161a3 commit edd992a
Show file tree
Hide file tree
Showing 8 changed files with 124 additions and 172 deletions.
70 changes: 28 additions & 42 deletions dist/MyLib.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions dist/MyLib.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 4 additions & 8 deletions src/bar.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
(function() {
'use strict';
module.exports = bar;

module.exports = bar;

function bar() {
return "world!";
}
}());
function bar() {
return "world!";
}
13 changes: 4 additions & 9 deletions src/foo.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
(function() {
'use strict';
module.exports = foo;

module.exports = foo;

function foo() {
return "Hello";
}

}());
function foo() {
return "Hello";
}
43 changes: 19 additions & 24 deletions src/main.js
Original file line number Diff line number Diff line change
@@ -1,29 +1,24 @@
(function() {
'use strict';
module.exports.getMessage = getMessage;
module.exports.sayHello = sayHello;
module.exports.sayHelloAsync = sayHelloAsync;

module.exports.getMessage = getMessage;
module.exports.sayHello = sayHello;
module.exports.sayHelloAsync = sayHelloAsync;
// If we are in a browser, define a global variable.
if (window) window.MyLib = module.exports;

// If we are in a browser, define a global variable.
if (window) window.MyLib = module.exports;
var foo = require("./foo.js");
var bar = require("./bar.js");

var foo = require("./foo.js");
var bar = require("./bar.js");
function getMessage() {
return foo() + " " + bar();
}

function getMessage() {
return foo() + " " + bar();
}
function sayHello(el) {
$(el).html(getMessage());
}

function sayHello(el) {
$(el).html(getMessage());
}

function sayHelloAsync(el, delay, callback) {
setTimeout(function() {
sayHello(el);
callback();
}, delay);
}

}());
function sayHelloAsync(el, delay, callback) {
setTimeout(function() {
sayHello(el);
callback();
}, delay);
}
42 changes: 18 additions & 24 deletions test/src/test-MyLib.js
Original file line number Diff line number Diff line change
@@ -1,31 +1,25 @@
(function() {
'use strict';
var assert = require("assert");
require("../../src/main.js");

var assert = require("assert");
require("../../src/main.js");
describe("MyLib", function() {
beforeEach(function() {
$("#message").html("");
});

describe("MyLib", function() {
beforeEach(function() {
$("#message").html("");
});
it("returns an important message", function() {
assert.equal(MyLib.getMessage(), "Hello world!");
});

it("returns an important message", function() {
assert.equal(MyLib.getMessage(), "Hello world!");
});
it("displays the message in the desired element", function() {
MyLib.sayHello("#message");
assert.equal($("#message").html(), MyLib.getMessage());
})

it("displays the message in the desired element", function() {
MyLib.sayHello("#message");
it("asynchronously displays the message in the desired element", function(done) {
MyLib.sayHelloAsync("#message", 10, function() {
assert.equal($("#message").html(), MyLib.getMessage());
})

it("asynchronously displays the message in the desired element", function(done) {
MyLib.sayHelloAsync("#message", 10, function() {
assert.equal($("#message").html(), MyLib.getMessage());
done();
});
})


done();
});
});

}());
});
28 changes: 12 additions & 16 deletions test/src/test-foobar.js
Original file line number Diff line number Diff line change
@@ -1,19 +1,15 @@
(function() {
'use strict';
var assert = require("assert");
var foo = require("../../src/foo.js");
var bar = require("../../src/bar.js");

var assert = require("assert");
var foo = require("../../src/foo.js");
var bar = require("../../src/bar.js");

describe("foo()", function() {
it("returns 'Hello'", function() {
assert.equal(foo(), "Hello");
});
describe("foo()", function() {
it("returns 'Hello'", function() {
assert.equal(foo(), "Hello");
});
});

describe("bar()", function() {
it("returns 'world!'", function() {
assert.equal(bar(), "world!");
})
})
}());
describe("bar()", function() {
it("returns 'world!'", function() {
assert.equal(bar(), "world!");
});
});
Loading

0 comments on commit edd992a

Please sign in to comment.