Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use textarea for texeditor sidebar field #94

Merged
merged 1 commit into from
Mar 20, 2025
Merged

Conversation

Aryan20
Copy link
Collaborator

@Aryan20 Aryan20 commented Mar 20, 2025

Description

If a sidebar field is a text editor field in ERPNext then that case is not handled, making it fallback to a simple input field.
The more acceptable approach is to use a textarea instead.
Text area allows expanding it's size, making it more readable aswell.

Screenshot/Screencast

Before
Screenshot 2025-03-20 at 5 24 36 PM

After
Screenshot 2025-03-20 at 5 26 12 PM

Checklist

  • I have carefully reviewed the code before submitting it for review.
  • This code is adequately covered by unit tests to validate its functionality.
  • I have conducted thorough testing to ensure it functions as intended.
  • A member of the QA team has reviewed and tested this PR (To be checked by QA or code reviewer)

Ref #89

@Aryan20 Aryan20 requested a review from niraj2477 March 20, 2025 11:58
@Aryan20 Aryan20 merged commit 7a5ec82 into develop Mar 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants