Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rename ability to lead and opportunity #86

Merged
merged 1 commit into from
Mar 24, 2025
Merged

add rename ability to lead and opportunity #86

merged 1 commit into from
Mar 24, 2025

Conversation

Aryan20
Copy link
Collaborator

@Aryan20 Aryan20 commented Mar 19, 2025

Description

Currently a Lead or Opportunity can be renamed from the the ERPNext backend but not from the Next CRM frontend.
This functionality can be added to the name labels.

Relevant Technical Choices

  1. Created a new modal which can rename and change title of a doc
  2. Used the name in doc as the trigger for the dialog box
  3. Added title fields with high priority as fallback breadcrumb and name choice.

Testing Instructions

  1. Open a opportunity or lead
  2. Click on the title part of it
  3. Type a new name or title
  4. Check that it successfully renames on action button click

Screenshot/Screencast

Screen.Recording.2025-03-20.at.4.29.29.AM.mov

Checklist

  • I have carefully reviewed the code before submitting it for review.
  • This code is adequately covered by unit tests to validate its functionality.
  • I have conducted thorough testing to ensure it functions as intended.
  • A member of the QA team has reviewed and tested this PR (To be checked by QA or code reviewer)

Fixes #84

@Aryan20 Aryan20 requested a review from niraj2477 March 20, 2025 06:59
@niraj2477
Copy link

@Aryan20 Some kind of indicator should be there, since it is not by default understood that user can click on name to rename the doc.

@Aryan20
Copy link
Collaborator Author

Aryan20 commented Mar 24, 2025

Updates - discussed in daily sync. The UI although lacking visual indicators is close to the one in ERPNext so would be intuitive enough.

@niraj2477 Please review.

@Aryan20 Aryan20 merged commit 57919c0 into develop Mar 24, 2025
1 check passed
@Aryan20 Aryan20 deleted the rename-doc branch March 26, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants