Media Library DAM management react component to handle the media requests [master] #15
Conversation
…media-library-block-react-drag
There was a problem hiding this comment.
Code analysis identified issues
action-phpcs-code-review has identified potential problems in this pull request during automated scanning. We recommend reviewing the issues noted and that they are resolved.
phpcs scanning turned up:
🚫 13 errors
Powered by rtCamp's GitHub Actions Library
Posting will continue in further review(s)
…media-library-block-react-drag
There was a problem hiding this comment.
Code analysis identified issues
action-phpcs-code-review has identified potential problems in this pull request during automated scanning. We recommend reviewing the issues noted and that they are resolved.
phpcs scanning turned up:
🚫 78 errors
Powered by rtCamp's GitHub Actions Library
Posting will continue in further review(s)
| filemtime( RT_TRANSCODER_PATH . '/assets/build/css/media-library.css' ) | ||
| ); | ||
|
|
||
| wp_localize_script( 'easydam-media-library', 'MediaLibraryTaxonomyFilterData', array( |
There was a problem hiding this comment.
🚫 Error: Opening parenthesis of a multi-line function call must be the last content on the line (PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket).
| filemtime( RT_TRANSCODER_PATH . '/assets/build/css/media-library.css' ) | ||
| ); | ||
|
|
||
| wp_localize_script( 'easydam-media-library', 'MediaLibraryTaxonomyFilterData', array( |
There was a problem hiding this comment.
🚫 Error: Only one argument is allowed per line in a multi-line function call (PEAR.Functions.FunctionCallSignature.MultipleArguments).
| ); | ||
|
|
||
| wp_localize_script( 'easydam-media-library', 'MediaLibraryTaxonomyFilterData', array( | ||
| 'terms' => get_terms( 'media-folder', array( 'hide_empty' => false ) ), |
There was a problem hiding this comment.
| ); | ||
|
|
||
| wp_localize_script( 'easydam-media-library', 'MediaLibraryTaxonomyFilterData', array( | ||
| 'terms' => get_terms( 'media-folder', array( 'hide_empty' => false ) ), |
There was a problem hiding this comment.
🚫 Error: The parameter "array( 'hide_empty' => false )" at position #2 of get_terms() has been deprecated since WordPress version 4.5.0. Instead do not pass the parameter (WordPress.WP.DeprecatedParameters.Get_termsParam2Found).
|
|
||
| wp_localize_script( 'easydam-media-library', 'MediaLibraryTaxonomyFilterData', array( | ||
| 'terms' => get_terms( 'media-folder', array( 'hide_empty' => false ) ), | ||
| ) ); |
There was a problem hiding this comment.
🚫 Error: Closing parenthesis of a multi-line function call must be on a line by itself (PEAR.Functions.FunctionCallSignature.CloseBracketLine).
|
|
||
| add_filter( 'restrict_manage_posts', array( $this, 'restrict_manage_media_filter' ) ); | ||
|
|
||
| } |
There was a problem hiding this comment.
🚫 Error: Function closing brace must go on the next line following the body; found 1 blank lines before brace (PSR2.Methods.FunctionClosingBrace.SpacingBeforeClose).
|
|
||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
🚫 Error: Doc comment for parameter "$query_args" missing (Squiz.Commenting.FunctionComment.MissingParamTag).
| /** | ||
| * Filter the media library arguments to include folders. | ||
| * | ||
| * @return void |
There was a problem hiding this comment.
🚫 Error: Function return type is void, but function contains return statement (Squiz.Commenting.FunctionComment.InvalidReturnVoid).
| */ | ||
| public function filter_media_library_by_taxonomy( $query_args ) { | ||
|
|
||
| if ( isset( $_REQUEST['query']['media-folder'] ) ) { |
There was a problem hiding this comment.
| public function filter_media_library_by_taxonomy( $query_args ) { | ||
|
|
||
| if ( isset( $_REQUEST['query']['media-folder'] ) ) { | ||
| $media_folder_id = intval( $_REQUEST['query']['media-folder'] ); |
There was a problem hiding this comment.
|
|
||
| if ( 0 === $media_folder_id ) { | ||
| // Handling uncategorized attachments (no term selected for attachment). | ||
| $query_args['tax_query'] = array( |
There was a problem hiding this comment.
| ), | ||
| ); | ||
|
|
||
| } elseif ( -1 === $media_folder_id ) { |
There was a problem hiding this comment.
🚫 Error: Empty ELSEIF statement detected (Generic.CodeAnalysis.EmptyStatement.DetectedElseif).
| ); | ||
|
|
||
| } elseif ( -1 === $media_folder_id ) { | ||
| }else if ( ! empty( $media_folder_id ) ) { |
There was a problem hiding this comment.
🚫 Error: Expected 1 space after closing brace; 0 found (Squiz.ControlStructures.ControlSignature.SpaceAfterCloseBrace).
| ); | ||
|
|
||
| } elseif ( -1 === $media_folder_id ) { | ||
| }else if ( ! empty( $media_folder_id ) ) { |
There was a problem hiding this comment.
| } elseif ( -1 === $media_folder_id ) { | ||
| }else if ( ! empty( $media_folder_id ) ) { | ||
| // Filter attachments by selected folder. | ||
| $query_args['tax_query'] = array( |
There was a problem hiding this comment.
| return $query_args; | ||
| } | ||
|
|
||
| public function pre_get_post_filter( $query ) { |
There was a problem hiding this comment.
🚫 Error: Missing doc comment for function pre_get_post_filter() (Squiz.Commenting.FunctionComment.Missing).
|
|
||
| public function pre_get_post_filter( $query ) { | ||
| if ( is_admin() && $query->is_main_query() && $query->get( 'post_type' ) === 'attachment' ) { | ||
| $media_folder = isset( $_GET['media-folder'] ) ? sanitize_text_field( $_GET['media-folder'] ) : null; |
There was a problem hiding this comment.
| $media_folder = isset( $_GET['media-folder'] ) ? sanitize_text_field( $_GET['media-folder'] ) : null; | ||
|
|
||
| if ( $media_folder && 'uncategorized' === $media_folder ) { | ||
| $query->set( 'tax_query', array( |
There was a problem hiding this comment.
🚫 Error: Opening parenthesis of a multi-line function call must be the last content on the line (PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket).
| $media_folder = isset( $_GET['media-folder'] ) ? sanitize_text_field( $_GET['media-folder'] ) : null; | ||
|
|
||
| if ( $media_folder && 'uncategorized' === $media_folder ) { | ||
| $query->set( 'tax_query', array( |
There was a problem hiding this comment.
🚫 Error: Only one argument is allowed per line in a multi-line function call (PEAR.Functions.FunctionCallSignature.MultipleArguments).
| ) | ||
| ), | ||
| ), | ||
| ) ); |
There was a problem hiding this comment.
🚫 Error: Closing parenthesis of a multi-line function call must be on a line by itself (PEAR.Functions.FunctionCallSignature.CloseBracketLine).
| ), | ||
| ) ); | ||
|
|
||
| } else if ( $media_folder && 'all' !== $media_folder ) { |
There was a problem hiding this comment.
| ) ); | ||
|
|
||
| } else if ( $media_folder && 'all' !== $media_folder ) { | ||
| $query->set( 'tax_query', array( |
There was a problem hiding this comment.
🚫 Error: Opening parenthesis of a multi-line function call must be the last content on the line (PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket).
| ) ); | ||
|
|
||
| } else if ( $media_folder && 'all' !== $media_folder ) { | ||
| $query->set( 'tax_query', array( |
There was a problem hiding this comment.
🚫 Error: Only one argument is allowed per line in a multi-line function call (PEAR.Functions.FunctionCallSignature.MultipleArguments).
| 'field' => 'term_id', | ||
| 'terms' => (int) $media_folder, | ||
| ), | ||
| ) ); |
There was a problem hiding this comment.
🚫 Error: Closing parenthesis of a multi-line function call must be on a line by itself (PEAR.Functions.FunctionCallSignature.CloseBracketLine).
| } | ||
| } | ||
|
|
||
| function restrict_manage_media_filter() { |
There was a problem hiding this comment.
🚫 Error: Missing doc comment for function restrict_manage_media_filter() (Squiz.Commenting.FunctionComment.Missing).
| } | ||
| } | ||
|
|
||
| function restrict_manage_media_filter() { |
There was a problem hiding this comment.
🚫 Error: Visibility must be declared on method "restrict_manage_media_filter" (Squiz.Scope.MethodScope.Missing).
| } | ||
| } | ||
|
|
||
| function restrict_manage_media_filter() { |
There was a problem hiding this comment.
🚫 Error: Please, make sure that a callback to 'restrict_manage_posts' filter is always returning some value (WordPressVIPMinimum.Hooks.AlwaysReturnInFilter.MissingReturnStatement).
| function restrict_manage_media_filter() { | ||
| $screen = get_current_screen(); | ||
|
|
||
| if ( $screen->id === 'upload' ) { |
There was a problem hiding this comment.
🚫 Error: Use Yoda Condition checks, you must (WordPress.PHP.YodaConditions.NotYoda).
| $screen = get_current_screen(); | ||
|
|
||
| if ( $screen->id === 'upload' ) { | ||
| // Get the current folder filter value from the URL |
There was a problem hiding this comment.
🚫 Error: Inline comments must end in full-stops, exclamation marks, or question marks (Squiz.Commenting.InlineComment.InvalidEndChar).
|
|
||
| if ( $screen->id === 'upload' ) { | ||
| // Get the current folder filter value from the URL | ||
| $media_folder = isset( $_GET['media-folder'] ) ? sanitize_text_field( $_GET['media-folder'] ) : 'all'; |
There was a problem hiding this comment.
| // Get the current folder filter value from the URL | ||
| $media_folder = isset( $_GET['media-folder'] ) ? sanitize_text_field( $_GET['media-folder'] ) : 'all'; | ||
|
|
||
| // Get all terms from the 'media-folder' taxonomy |
There was a problem hiding this comment.
🚫 Error: Inline comments must end in full-stops, exclamation marks, or question marks (Squiz.Commenting.InlineComment.InvalidEndChar).
| $media_folder = isset( $_GET['media-folder'] ) ? sanitize_text_field( $_GET['media-folder'] ) : 'all'; | ||
|
|
||
| // Get all terms from the 'media-folder' taxonomy | ||
| $terms = get_terms( array( |
There was a problem hiding this comment.
🚫 Error: Opening parenthesis of a multi-line function call must be the last content on the line (PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket).
| $terms = get_terms( array( | ||
| 'taxonomy' => 'media-folder', | ||
| 'hide_empty' => false, | ||
| ) ); |
There was a problem hiding this comment.
🚫 Error: Closing parenthesis of a multi-line function call must be on a line by itself (PEAR.Functions.FunctionCallSignature.CloseBracketLine).
| 'hide_empty' => false, | ||
| ) ); | ||
|
|
||
| // Define default options |
There was a problem hiding this comment.
🚫 Error: Inline comments must end in full-stops, exclamation marks, or question marks (Squiz.Commenting.InlineComment.InvalidEndChar).
| $folders = array( | ||
| (object) array( | ||
| 'id' => 'uncategorized', | ||
| 'name' => __( 'Uncategorized', 'textdomain' ), |
There was a problem hiding this comment.
🚫 Error: Mismatched text domain. Expected 'transcoder' but got 'textdomain' (WordPress.WP.I18n.TextDomainMismatch).
| ), | ||
| (object) array( | ||
| 'id' => 'all', | ||
| 'name' => __( 'All collections', 'textdomain' ), |
There was a problem hiding this comment.
🚫 Error: Mismatched text domain. Expected 'transcoder' but got 'textdomain' (WordPress.WP.I18n.TextDomainMismatch).
| ), | ||
| ); | ||
|
|
||
| // Add taxonomy terms to the folder list |
There was a problem hiding this comment.
🚫 Error: Inline comments must end in full-stops, exclamation marks, or question marks (Squiz.Commenting.InlineComment.InvalidEndChar).
| ); | ||
| } | ||
|
|
||
| // Render the dropdown |
There was a problem hiding this comment.
🚫 Error: Inline comments must end in full-stops, exclamation marks, or question marks (Squiz.Commenting.InlineComment.InvalidEndChar).
| }, | ||
| 'args' => array( | ||
| 'attachment_ids' => array( | ||
| 'required' => true, |
There was a problem hiding this comment.
| 'args' => array( | ||
| 'attachment_ids' => array( | ||
| 'required' => true, | ||
| 'type' => 'array', |
There was a problem hiding this comment.
| 'attachment_ids' => array( | ||
| 'required' => true, | ||
| 'type' => 'array', | ||
| 'items' => array( 'type' => 'integer' ), |
There was a problem hiding this comment.
| 'description' => 'Array of attachment IDs to associate.', | ||
| ), | ||
| 'folder_term_id' => array( | ||
| 'required' => true, |
There was a problem hiding this comment.
| ), | ||
| 'folder_term_id' => array( | ||
| 'required' => true, | ||
| 'type' => 'integer', |
There was a problem hiding this comment.
| ), | ||
|
|
||
| ), | ||
| ) |
There was a problem hiding this comment.
🚫 Error: There should be a comma after the last array item in a multi-line array (NormalizedArrays.Arrays.CommaAfterLast.MissingMultiLine).
| * @param \WP_REST_Request $request REST API request. | ||
| * @return \WP_REST_Response | ||
| */ | ||
| function assign_images_to_folder( $request ) { |
There was a problem hiding this comment.
🚫 Error: Visibility must be declared on method "assign_images_to_folder" (Squiz.Scope.MethodScope.Missing).
| } | ||
| } | ||
|
|
||
| return rest_ensure_response( array( |
There was a problem hiding this comment.
🚫 Error: Opening parenthesis of a multi-line function call must be the last content on the line (PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket).
| return rest_ensure_response( array( | ||
| 'success' => true, | ||
| 'message' => 'Attachments successfully associated with the folder.', | ||
| ) ); |
There was a problem hiding this comment.
🚫 Error: Closing parenthesis of a multi-line function call must be on a line by itself (PEAR.Functions.FunctionCallSignature.CloseBracketLine).
|
|
||
| namespace Transcoder\Inc\Taxonomies; | ||
|
|
||
| use \Transcoder\Inc\Traits\Singleton; |
There was a problem hiding this comment.
🚫 Error: An import use statement should never start with a leading backslash (Universal.UseStatements.NoLeadingBackslash.LeadingBackslashFound).
|
|
||
| $this->setup_hooks(); | ||
|
|
||
| } |
There was a problem hiding this comment.
🚫 Error: Function closing brace must go on the next line following the body; found 1 blank lines before brace (PSR2.Methods.FunctionClosingBrace.SpacingBeforeClose).
| */ | ||
| protected function setup_hooks() { | ||
|
|
||
| add_action( 'init', [ $this, 'register_taxonomy' ] ); |
There was a problem hiding this comment.
🚫 Error: Short array syntax is not allowed (Universal.Arrays.DisallowShortArraySyntax.Found).
|
|
||
| add_action( 'init', [ $this, 'register_taxonomy' ] ); | ||
|
|
||
| } |
There was a problem hiding this comment.
🚫 Error: Function closing brace must go on the next line following the body; found 1 blank lines before brace (PSR2.Methods.FunctionClosingBrace.SpacingBeforeClose).
| } | ||
|
|
||
| $args = $this->get_args(); | ||
| $args = ( ! empty( $args ) && is_array( $args ) ) ? $args : []; |
There was a problem hiding this comment.
🚫 Error: Short array syntax is not allowed (Universal.Arrays.DisallowShortArraySyntax.Found).
| $args = ( ! empty( $args ) && is_array( $args ) ) ? $args : []; | ||
|
|
||
| $labels = $this->get_labels(); | ||
| $labels = ( ! empty( $labels ) && is_array( $labels ) ) ? $labels : []; |
There was a problem hiding this comment.
🚫 Error: Short array syntax is not allowed (Universal.Arrays.DisallowShortArraySyntax.Found).
|
|
||
| register_taxonomy( static::SLUG, $post_types, $args ); | ||
|
|
||
| } |
There was a problem hiding this comment.
🚫 Error: Function closing brace must go on the next line following the body; found 1 blank lines before brace (PSR2.Methods.FunctionClosingBrace.SpacingBeforeClose).
| */ | ||
| public function get_args() { | ||
|
|
||
| return [ |
There was a problem hiding this comment.
🚫 Error: Short array syntax is not allowed (Universal.Arrays.DisallowShortArraySyntax.Found).
| 'show_in_rest' => true, | ||
| ]; | ||
|
|
||
| } |
There was a problem hiding this comment.
🚫 Error: Function closing brace must go on the next line following the body; found 1 blank lines before brace (PSR2.Methods.FunctionClosingBrace.SpacingBeforeClose).
| */ | ||
| abstract public function get_post_types(); | ||
|
|
||
| } |
There was a problem hiding this comment.
🚫 Error: The closing brace for the class must go on the next line after the body (PSR2.Classes.ClassDeclaration.CloseBraceAfterBody).
| */ | ||
| public function get_labels() { | ||
|
|
||
| return [ |
There was a problem hiding this comment.
🚫 Error: Short array syntax is not allowed (Universal.Arrays.DisallowShortArraySyntax.Found).
| public function get_labels() { | ||
|
|
||
| return [ | ||
| 'name' => _x('Media Folders', 'Media Folder', 'transcoder'), |
There was a problem hiding this comment.
🚫 Error: Expected 1 spaces after opening parenthesis; 0 found (PEAR.Functions.FunctionCallSignature.SpaceAfterOpenBracket).
| public function get_labels() { | ||
|
|
||
| return [ | ||
| 'name' => _x('Media Folders', 'Media Folder', 'transcoder'), |
There was a problem hiding this comment.
🚫 Error: Expected 1 spaces before closing parenthesis; 0 found (PEAR.Functions.FunctionCallSignature.SpaceBeforeCloseBracket).
|
|
||
| return [ | ||
| 'name' => _x('Media Folders', 'Media Folder', 'transcoder'), | ||
| 'singular_name' => _x('Media Folder', 'Media Folder', 'transcoder'), |
There was a problem hiding this comment.
🚫 Error: Expected 1 spaces after opening parenthesis; 0 found (PEAR.Functions.FunctionCallSignature.SpaceAfterOpenBracket).
|
|
||
| return [ | ||
| 'name' => _x('Media Folders', 'Media Folder', 'transcoder'), | ||
| 'singular_name' => _x('Media Folder', 'Media Folder', 'transcoder'), |
There was a problem hiding this comment.
🚫 Error: Expected 1 spaces before closing parenthesis; 0 found (PEAR.Functions.FunctionCallSignature.SpaceBeforeCloseBracket).
| return [ | ||
| 'name' => _x('Media Folders', 'Media Folder', 'transcoder'), | ||
| 'singular_name' => _x('Media Folder', 'Media Folder', 'transcoder'), | ||
| 'search_items' => __('Search Media Folders', 'transcoder'), |
There was a problem hiding this comment.
🚫 Error: Expected 1 spaces after opening parenthesis; 0 found (PEAR.Functions.FunctionCallSignature.SpaceAfterOpenBracket).
| return [ | ||
| 'name' => _x('Media Folders', 'Media Folder', 'transcoder'), | ||
| 'singular_name' => _x('Media Folder', 'Media Folder', 'transcoder'), | ||
| 'search_items' => __('Search Media Folders', 'transcoder'), |
There was a problem hiding this comment.
🚫 Error: Expected 1 spaces before closing parenthesis; 0 found (PEAR.Functions.FunctionCallSignature.SpaceBeforeCloseBracket).
| 'name' => _x('Media Folders', 'Media Folder', 'transcoder'), | ||
| 'singular_name' => _x('Media Folder', 'Media Folder', 'transcoder'), | ||
| 'search_items' => __('Search Media Folders', 'transcoder'), | ||
| 'all_items' => __('All Media Folders', 'transcoder'), |
There was a problem hiding this comment.
🚫 Error: Expected 1 spaces after opening parenthesis; 0 found (PEAR.Functions.FunctionCallSignature.SpaceAfterOpenBracket).
| 'name' => _x('Media Folders', 'Media Folder', 'transcoder'), | ||
| 'singular_name' => _x('Media Folder', 'Media Folder', 'transcoder'), | ||
| 'search_items' => __('Search Media Folders', 'transcoder'), | ||
| 'all_items' => __('All Media Folders', 'transcoder'), |
There was a problem hiding this comment.
🚫 Error: Expected 1 spaces before closing parenthesis; 0 found (PEAR.Functions.FunctionCallSignature.SpaceBeforeCloseBracket).
| 'singular_name' => _x('Media Folder', 'Media Folder', 'transcoder'), | ||
| 'search_items' => __('Search Media Folders', 'transcoder'), | ||
| 'all_items' => __('All Media Folders', 'transcoder'), | ||
| 'parent_item' => __('Parent Folder', 'transcoder'), |
There was a problem hiding this comment.
🚫 Error: Expected 1 spaces after opening parenthesis; 0 found (PEAR.Functions.FunctionCallSignature.SpaceAfterOpenBracket).
| 'singular_name' => _x('Media Folder', 'Media Folder', 'transcoder'), | ||
| 'search_items' => __('Search Media Folders', 'transcoder'), | ||
| 'all_items' => __('All Media Folders', 'transcoder'), | ||
| 'parent_item' => __('Parent Folder', 'transcoder'), |
There was a problem hiding this comment.
🚫 Error: Expected 1 spaces before closing parenthesis; 0 found (PEAR.Functions.FunctionCallSignature.SpaceBeforeCloseBracket).
| 'search_items' => __('Search Media Folders', 'transcoder'), | ||
| 'all_items' => __('All Media Folders', 'transcoder'), | ||
| 'parent_item' => __('Parent Folder', 'transcoder'), | ||
| 'parent_item_colon' => __('Parent Folder:', 'transcoder'), |
There was a problem hiding this comment.
🚫 Error: Expected 1 spaces after opening parenthesis; 0 found (PEAR.Functions.FunctionCallSignature.SpaceAfterOpenBracket).
| 'search_items' => __('Search Media Folders', 'transcoder'), | ||
| 'all_items' => __('All Media Folders', 'transcoder'), | ||
| 'parent_item' => __('Parent Folder', 'transcoder'), | ||
| 'parent_item_colon' => __('Parent Folder:', 'transcoder'), |
There was a problem hiding this comment.
🚫 Error: Expected 1 spaces before closing parenthesis; 0 found (PEAR.Functions.FunctionCallSignature.SpaceBeforeCloseBracket).
rtBot
dismissed
their stale review
Dismissing review as all inline comments are obsolete by now
PR Description
Screen.Recording.2024-12-18.at.10.35.16.AM.mov