Add Video Layers on Frontend #14

subodhr258 · 2024-12-17T14:05:26Z

This PR adds the following features:

Used render.php to display the video and gravityform shortcodes on the frontend
Displayed the Form/CTA over the video at the specified Display Time
When the form is submitted, added an observer to change "Skip" to "Continue"
Disallowed user from bypassing the overlay by temporarily hiding controls
When "allow_skip" value is false, the Skip button is hidden, and becomes visible as "Continue" when form is submitted.

Demo Recording

Screen.Recording.2024-12-17.at.7.32.38.PM.mov

rtBot

Previous scan continued.

rtBot · 2024-12-17T14:06:59Z

assets/src/blocks/easydam-player/render.php

+$video_setup = wp_json_encode(
+	array(
+		'controls' => $controls,
+		'autoplay' => $autoplay,


⚠️ Warning: Array double arrow not aligned correctly; expected 5 space(s) between "'autoplay'" and double arrow, but found 1 (WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned).

rtBot · 2024-12-17T14:06:59Z

assets/src/blocks/easydam-player/render.php

+	array(
+		'controls' => $controls,
+		'autoplay' => $autoplay,
+		'loop'     => $loop,


⚠️ Warning: Array double arrow not aligned correctly; expected 9 space(s) between "'loop'" and double arrow, but found 5 (WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned).

rtBot · 2024-12-17T14:06:59Z

assets/src/blocks/easydam-player/render.php

+		'controls' => $controls,
+		'autoplay' => $autoplay,
+		'loop'     => $loop,
+		'muted'    => $muted,


⚠️ Warning: Array double arrow not aligned correctly; expected 8 space(s) between "'muted'" and double arrow, but found 4 (WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned).

rtBot · 2024-12-17T14:06:59Z

assets/src/blocks/easydam-player/render.php

+		'autoplay' => $autoplay,
+		'loop'     => $loop,
+		'muted'    => $muted,
+		'preload'  => $preload,


⚠️ Warning: Array double arrow not aligned correctly; expected 6 space(s) between "'preload'" and double arrow, but found 2 (WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned).

rtBot · 2024-12-17T14:06:59Z

assets/src/blocks/easydam-player/render.php

+		'loop'     => $loop,
+		'muted'    => $muted,
+		'preload'  => $preload,
+		'poster'   => $poster,


⚠️ Warning: Array double arrow not aligned correctly; expected 7 space(s) between "'poster'" and double arrow, but found 3 (WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned).

rtBot · 2024-12-17T14:06:59Z

assets/src/blocks/easydam-player/render.php

+		'muted'    => $muted,
+		'preload'  => $preload,
+		'poster'   => $poster,
+		'fluid'    => true,


⚠️ Warning: Array double arrow not aligned correctly; expected 8 space(s) between "'fluid'" and double arrow, but found 4 (WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned).

rtBot · 2024-12-17T14:06:59Z

assets/src/blocks/easydam-player/render.php

+		'preload'  => $preload,
+		'poster'   => $poster,
+		'fluid'    => true,
+		'sources'  => $sources,


⚠️ Warning: Array double arrow not aligned correctly; expected 6 space(s) between "'sources'" and double arrow, but found 2 (WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned).

rtBot · 2024-12-17T14:06:59Z

assets/src/blocks/easydam-player/render.php

+		'poster'   => $poster,
+		'fluid'    => true,
+		'sources'  => $sources,
+		'id'       => $id,


⚠️ Warning: Array double arrow not aligned correctly; expected 11 space(s) between "'id'" and double arrow, but found 7 (WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned).

rtBot · 2024-12-17T14:06:59Z

assets/src/blocks/easydam-player/render.php

+		'fluid'    => true,
+		'sources'  => $sources,
+		'id'       => $id,
+		'easydam_meta'     => $easydam_meta_data,


⚠️ Warning: Array double arrow not aligned correctly; expected 1 space(s) between "'easydam_meta'" and double arrow, but found 5 (WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned).

rtBot · 2024-12-17T14:06:59Z

assets/src/blocks/easydam-player/render.php

+	<?php endif; ?>
+
+	<!-- Dynamically render shortcodes for form layers -->
+	<?php if ( ! empty( $easydam_meta_data['layers'] ) ) :


🚫 Error: Opening PHP tag must be on a line by itself (Squiz.PHP.EmbeddedPhp.ContentAfterOpen).

rtBot

Previous scan continued.

rtBot · 2024-12-17T14:07:04Z

assets/src/blocks/easydam-player/render.php

+	<!-- Dynamically render shortcodes for form layers -->
+	<?php if ( ! empty( $easydam_meta_data['layers'] ) ) :
+		foreach ( $easydam_meta_data['layers'] as $layer ) :
+			if ( isset( $layer['type'] ) && $layer['type'] === 'form' && ! empty( $layer['gf_id'] ) ) : ?>


🚫 Error: Use Yoda Condition checks, you must (WordPress.PHP.YodaConditions.NotYoda).

rtBot · 2024-12-17T14:07:04Z

assets/src/blocks/easydam-player/render.php

+	<!-- Dynamically render shortcodes for form layers -->
+	<?php if ( ! empty( $easydam_meta_data['layers'] ) ) :
+		foreach ( $easydam_meta_data['layers'] as $layer ) :
+			if ( isset( $layer['type'] ) && $layer['type'] === 'form' && ! empty( $layer['gf_id'] ) ) : ?>


🚫 Error: Closing PHP tag must be on a line by itself (Squiz.PHP.EmbeddedPhp.ContentBeforeEnd).

rtBot · 2024-12-17T14:07:04Z

assets/src/blocks/easydam-player/render.php

+			if ( isset( $layer['type'] ) && $layer['type'] === 'form' && ! empty( $layer['gf_id'] ) ) : ?>
+				<div id="layer-<?php echo esc_attr( $layer['id'] ); ?>" class="easydam-layer hidden">
+					<?php 
+						echo do_shortcode( sprintf(


🚫 Error: Opening parenthesis of a multi-line function call must be the last content on the line (PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket).

rtBot · 2024-12-17T14:07:04Z

assets/src/blocks/easydam-player/render.php

+						echo do_shortcode( sprintf(
+							"[gravityform id='%d' title='false' description='false' ajax='true']",
+							intval( $layer['gf_id'] )
+						) );


🚫 Error: Closing parenthesis of a multi-line function call must be on a line by itself (PEAR.Functions.FunctionCallSignature.CloseBracketLine).

rtBot · 2024-12-17T14:07:04Z

assets/src/blocks/easydam-player/render.php

+						) );
+					?>
+				</div>
+			<?php elseif ( isset( $layer['type'] ) && $layer['type'] === 'cta' ) : ?>


🚫 Error: Use Yoda Condition checks, you must (WordPress.PHP.YodaConditions.NotYoda).

rtBot · 2024-12-17T14:07:04Z

assets/src/blocks/easydam-player/render.php

+					<!-- Add sample button for now -->
+					<button class="cta-button">Call To Action</button>
+				</div>
+			<?php endif; 


🚫 Error: Opening PHP tag must be on a line by itself (Squiz.PHP.EmbeddedPhp.ContentAfterOpen).

rtBot · 2024-12-17T14:07:04Z

assets/src/blocks/easydam-player/render.php

+				</div>
+			<?php endif; 
+		endforeach;
+	endif; ?>


🚫 Error: Closing PHP tag must be on a line by itself (Squiz.PHP.EmbeddedPhp.ContentBeforeEnd).

rtBot · 2024-12-17T14:07:04Z

assets/src/blocks/easydam-player/render.php

+	endif; ?>
+	</div>
+</figure>
+<?php endif;


🚫 Error: Opening PHP tag must be on a line by itself (Squiz.PHP.EmbeddedPhp.ContentAfterOpen).

rtBot · 2024-12-17T14:13:45Z

GitHub API communication error. Please contact a human. (commit-ID: bac1a68).

Dismissing review as all inline comments are obsolete by now

KMchaudhary · 2024-12-18T03:33:24Z

phpcs.xml

@@ -37,9 +37,9 @@
 		 The minimum version set here should be in line with the minimum WP version
 		 as set in the "Requires at least" tag in the readme.txt file. -->
 	<rule ref="WordPress.WP.DeprecatedFunctions">
-		<properties>
+		<!-- <properties>


Uncommented the phpcs rule.

subodhr258 added 9 commits December 17, 2024 14:56

feat: Add render.php for EasyDAM Player frontend

1ffa96f

feat: Remove additional sources for video player

d618626

feat: Add video data in data-setup inside render.php

58b6a6b

feat: Fetch gravity forms dynamically

0a012d5

feat: Apply layers to video at their display time

c9acffc

feat: Add Mutation Observer to convert Skip Button to Continue

e2de17b

feat: Disallow user from bypassing the overlay

570fdc1

feat: Hide skip button when Allow Skip is false

678a9fd

chore: Merged feat/player-frontend to master

f6e9ffb

This comment was marked as resolved.

Sign in to view

rtBot previously requested changes Dec 17, 2024

View reviewed changes

fix: Fixed PHPCS Issues

bac1a68

This comment was marked as resolved.

Sign in to view

subodhr258 marked this pull request as ready for review December 17, 2024 14:37

subodhr258 requested a review from KMchaudhary December 17, 2024 14:41

KMchaudhary reviewed Dec 18, 2024

View reviewed changes

KMchaudhary approved these changes Dec 18, 2024

View reviewed changes

KMchaudhary merged commit cf8732a into master Dec 18, 2024
1 of 3 checks passed

subodhr258 deleted the feat/player-frontend branch February 26, 2025 14:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Video Layers on Frontend #14

Add Video Layers on Frontend #14

subodhr258 commented Dec 17, 2024

This comment was marked as resolved.

This comment was marked as resolved.

rtBot left a comment

rtBot Dec 17, 2024

rtBot Dec 17, 2024

rtBot Dec 17, 2024

rtBot Dec 17, 2024

rtBot Dec 17, 2024

rtBot Dec 17, 2024

rtBot Dec 17, 2024

rtBot Dec 17, 2024

rtBot Dec 17, 2024

rtBot Dec 17, 2024

rtBot left a comment

rtBot Dec 17, 2024

rtBot Dec 17, 2024

rtBot Dec 17, 2024

rtBot Dec 17, 2024

rtBot Dec 17, 2024

rtBot Dec 17, 2024

rtBot Dec 17, 2024

rtBot Dec 17, 2024

This comment was marked as resolved.

rtBot commented Dec 17, 2024

KMchaudhary Dec 18, 2024

Add Video Layers on Frontend #14

Add Video Layers on Frontend #14

Conversation

subodhr258 commented Dec 17, 2024

Demo Recording

This comment was marked as resolved.

This comment was marked as resolved.

rtBot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rtBot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment was marked as resolved.

rtBot commented Dec 17, 2024

Choose a reason for hiding this comment