Fix 224-shinymeta: add explicit varname to metaReactive calls#342
Closed
karangattu wants to merge 1 commit intofix-tests-feb-27from
Closed
Fix 224-shinymeta: add explicit varname to metaReactive calls#342karangattu wants to merge 1 commit intofix-tests-feb-27from
karangattu wants to merge 1 commit intofix-tests-feb-27from
Conversation
shinymeta's auto-detection of variable names via source references (mrexprSrcrefToLabel) crashes with shiny >= 1.13.0.9000 due to changed source reference behavior in callModule(). The while loop in mrexprSrcrefToLabel can decrement firstLineIdx to 0, causing lines[0] to return character(0) which crashes the grepl() check. Adding explicit varname parameters bypasses the broken auto-detection.
schloerke
requested changes
Feb 27, 2026
Contributor
Author
|
Waiting for this to get fixed in shinymeta instead of going around the issue |
Contributor
|
Should be fixed via rstudio/shinymeta#131 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shinymeta's auto-detection of variable names via source references (mrexprSrcrefToLabel) crashes with shiny >= 1.13.0.9000 due to changed source reference behavior in callModule(). The while loop in mrexprSrcrefToLabel can decrement firstLineIdx to 0, causing lines[0] to return character(0) which crashes the grepl() check.
Adding explicit varname parameters bypasses the broken auto-detection.