Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt another bind when registering a binding outside a renderHtml() context #3638

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Attempt another bind when registering a binding outside a renderHtml() context #3638

wants to merge 14 commits into from
+1,022 −802

Conversation

cpsievert
Copy link
Collaborator

Closes #3635

@cpsievert cpsievert requested a review from jcheng5 May 18, 2022 23:06
@cpsievert cpsievert force-pushed the bindAfterRegister branch from c163286 to fe803e0 Compare May 18, 2022 23:07
@cpsievert cpsievert mentioned this pull request May 18, 2022
Merged
cpsievert
cpsievert commented May 20, 2022
View reviewed changes
srcts/src/shiny/render.ts Outdated Show resolved Hide resolved
cpsievert added a commit to posit-dev/py-shiny that referenced this pull request May 23, 2022
@cpsievert
Incorporate rstudio/shiny#3638 to address posit-dev/py-shinywidgets#36
63039d9
@cpsievert cpsievert mentioned this pull request May 23, 2022
Merged
cpsievert added a commit to posit-dev/py-shiny that referenced this pull request May 24, 2022
@cpsievert
Incorporate rstudio/shiny#3638 to address posit-dev/py-shinywidgets#36
ef15acb
@cpsievert cpsievert force-pushed the bindAfterRegister branch from aecc3b0 to 891ed0f Compare June 14, 2022 21:49
cpsievert added a commit to posit-dev/py-shiny that referenced this pull request Jun 14, 2022
@cpsievert
Incorporate rstudio/shiny#3638 to address posit-dev/py-shinywidgets#36 (
67350d1 
#174)
@cpsievert cpsievert force-pushed the bindAfterRegister branch from 891ed0f to d0bf86e Compare July 7, 2022 18:37
cpsievert
cpsievert commented Feb 7, 2023
View reviewed changes
srcts/src/shiny/init.ts Outdated Show resolved Hide resolved
cpsievert
cpsievert commented Mar 29, 2023
View reviewed changes
srcts/src/shiny/init.ts Outdated Show resolved Hide resolved
wch
wch reviewed Mar 30, 2023
View reviewed changes
srcts/src/shiny/init.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wch wch wch left review comments

@jcheng5 jcheng5 Awaiting requested review from jcheng5

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bindings can't be registered asynchronously
2 participants
@cpsievert @wch