Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Workbench to v2024.09.0 #845

Merged
merged 12 commits into from
Sep 24, 2024
Merged

Bump Workbench to v2024.09.0 #845

merged 12 commits into from
Sep 24, 2024

Conversation

zachhannum
Copy link
Contributor

No description provided.

samcofer and others added 9 commits June 28, 2024 16:07
@samcofer
Merge pull request #810 from rstudio/dev
94e8642 
Merge tag changes to main
@ianpittwood
Merge pull request #817 from rstudio/dev
fab7faa 
Merge `dev` to `main`
@ianpittwood
Merge pull request #825 from rstudio/dev
f3d947d 
Merge dev to main
@tylfin
Merge pull request #827 from rstudio/dev
303d477 
Bump PPM main to `2024.08.0-6`
@ianpittwood
Merge pull request #830 from rstudio/dev
a0b4bc4 
Deploy Workbench home directory permissions fix
@ianpittwood
Merge pull request #839 from rstudio/dev
2988d13 
Merge dev to main
@jonyoder
Merge pull request #842 from rstudio/dev
73ee692 
Merge dev to main for PPM 2024.08.2-9
@bschwedler
Merge pull request #843 from rstudio/dev
b10466d 
Merge fix for broken `sed` command on MacOS
@zachhannum
Bump Workbench version to 2024.09.0+375.pro3
bbf7fe9
@zachhannum zachhannum requested a review from GCRev September 24, 2024 13:41
@zachhannum zachhannum changed the base branch from dev to main September 24, 2024 13:41
melissa-barca
melissa-barca approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@melissa-barca melissa-barca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bschwedler
Copy link
Contributor

bschwedler commented Sep 24, 2024 •
edited
Loading

@zachhannum I updated the goss tests for GCW and azureML to use the pwb-code-server location.

Failures/Skipped:

File: /usr/lib/rstudio-server/bin/code-server/bin/code-server: exists:
Expected
    false
to equal
    true

Total Duration: 20.209s
Count: 234, Failed: 1, Skipped: 0

melissa-barca
melissa-barca requested changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@melissa-barca melissa-barca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops was too quick with my LGTM, we'll need to make some changes to the vscode.conf files to use PWB Code Server and possibly other updates as well. I'll push a commit for this.

@bschwedler bschwedler mentioned this pull request Sep 24, 2024
Merged
@bschwedler
Copy link
Contributor

@melissa-barca in parallel, I am updating the R/Python versions for Workbench to the latest patch release in #846

@melissa-barca
Updates to support PWB Code Server.
5019205 
* Remove maybe_install_vs_code as the versions that depend on this are
  no longer supported.
* Update default VS Code URL to PWB Code Server.
* Remove `--verbose` arg that isn't supported by PWB Code Server
@zachhannum zachhannum mentioned this pull request Sep 24, 2024
Merged
GCRev
GCRev reviewed Sep 24, 2024
View reviewed changes
workbench-for-google-cloud-workstations/conf/vscode.conf
@@ -1,4 +1,4 @@
enabled=1
args=--verbose --host=0.0.0.0
args=--host=0.0.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bschwedler bschwedler changed the base branch from main to dev September 24, 2024 16:22
GCRev
GCRev approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@GCRev GCRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bschwedler
Copy link
Contributor

I changed the merge target to the dev branch so that we can release the R/Python updates and the workbench updates at the same time.

@bschwedler bschwedler merged commit f50ba2f into dev Sep 24, 2024
37 checks passed
@bschwedler bschwedler deleted the bump-pwb-2024.09.0 branch September 24, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bschwedler bschwedler bschwedler approved these changes

@melissa-barca melissa-barca melissa-barca approved these changes

@GCRev GCRev GCRev approved these changes

@ianpittwood ianpittwood ianpittwood approved these changes

@cm421 cm421 Awaiting requested review from cm421 cm421 is a code owner

@colearendt colearendt Awaiting requested review from colearendt

@costrouc costrouc Awaiting requested review from costrouc costrouc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@zachhannum @bschwedler @melissa-barca @GCRev @ianpittwood @samcofer @tylfin @jonyoder