Extract common operations to reusable scripts in base images #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianpittwood
force-pushed
the
base-image-scripts
branch
from
f80b49a to
1f3613e
Compare
ianpittwood
force-pushed
the
base-image-scripts
branch
from
5bb7666 to
0e80052
Compare
ianpittwood
requested review from
colearendt,
bschwedler and
costrouc
as code owners
Merged
Provide a buildx config for GHA Unify test sleep behavior of Workbench images
Fix hadolint issues
ianpittwood
force-pushed
the
base-image-scripts
branch
from
1b85bf7 to
16b6328
Compare
kfeinauer
approved these changes
Apr 18, 2024
| *) | ||
| # Allow clean, update to be used as commands | ||
| if [ "$UPDATE" -eq 1 ] || [ "$CLEAN" -eq 1 ]; then | ||
| exit 0 |
There was a problem hiding this comment.
Consider sharing logic with yum script? Lots of similarities in these two scripts. Just a suggestion, not a hard blocker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #616
This change implements scripts we currently use for building Marketplaces images using Packer. By including these common scripts we can reduce the complexity of individual Dockerfiles in future changes, easily modify or extend downstream images, and increase our code sharing for common operations.
Adds
install_python.shinstall_r.shinstall_quarto.shinstall_drivers.shapt.shoryum.shfor package management Ubuntu and RHEL respectivelyChanges
product/baseandproduct/proimages to use shared scripts for installing dependencies.deps/for both base image directories.