Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #699 from rstudio/kg-quarto-update-1.4.550" #711

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

bschwedler
Copy link
Contributor

This reverts commit 2fa5480, reversing
changes made to e0fa3ab.

We do not want to update Quarto globally across all images due to the
coordination required across the helm charts for the individual
products.

This reverts commit 2fa5480, reversing
changes made to e0fa3ab.

We do not want to update Quarto globally across all images due to the
coordination required across the helm charts for the individual
products.
@bschwedler bschwedler requested a review from a team as a code owner March 22, 2024 13:52
@bschwedler bschwedler added the connect Specific to connect images label Mar 22, 2024
@bschwedler bschwedler requested a review from colearendt as a code owner March 22, 2024 13:52
@bschwedler bschwedler added dependencies Updates to dependency files product-base Related to the product base images labels Mar 22, 2024
@bschwedler bschwedler requested review from aronatkins and kgartland-rstudio and removed request for a team and colearendt March 22, 2024 13:52
Copy link

@kgartland-rstudio kgartland-rstudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bschwedler bschwedler mentioned this pull request Mar 22, 2024
@bschwedler
Copy link
Contributor Author

The test for the Quarto version in the product-base-pro image builds is failing because it cannot find the "correct" version of Quarto.

Digging into it, it looks like this is because the images are not pushed to GHCR on a branch, and the product-base image is getting pulled from a tag like

ghcr.io/rstudio/product-base-dev:ubuntu2204-r4.2.3_4.1.3-py3.12.1_3.11.7@sha256:aaee87e8d1e00f3c23263473699edce88226ce5842dc1a68ca59c6f70500887f
± docker run --rm -it ghcr.io/rstudio/product-base-dev:ubuntu2204-r4.2.3_4.1.3-py3.12.1_3.11.7@sha256:aaee87e8d1e00f3c23263473699edce88226ce5842dc1a68ca59c6f70500887f /bin/bash -c "ls /opt/quarto/"
1.4.550

I am going to merge this into dev so that the product-base-dev images get updated appropriately.
This is something we will need to resolve in the updated workflows.

@bschwedler bschwedler merged commit d075a3c into dev Mar 22, 2024
76 of 83 checks passed
@bschwedler bschwedler deleted the revert-699 branch March 22, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connect Specific to connect images dependencies Updates to dependency files product-base Related to the product base images
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants