Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for Workbench 2022.07.4 backwards compatibility #658

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Updates for Workbench 2022.07.4 backwards compatibility #658

merged 3 commits into from
Nov 8, 2023

Conversation

ianpittwood
Copy link
Collaborator

@ianpittwood ianpittwood commented Nov 8, 2023 •
edited
Loading

  • Add backwards compatibility for VS Code installation in older RSW versions
  • Add option to force downloading from S3 where applicable
  • Fix default tagging behavior in workbench/Justfile
  • Use shared _get-rsw-download-url target in workbench/Justfile

@ianpittwood ianpittwood changed the title Rsw 2022.07.4 Updates for 2022.07.4 Nov 8, 2023
@ianpittwood ianpittwood changed the title Updates for 2022.07.4 Updates for Workbench 2022.07.4 backwards compatibility Nov 8, 2023
@ianpittwood ianpittwood marked this pull request as ready for review November 8, 2023 19:25
kfeinauer
kfeinauer approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@kfeinauer kfeinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ianpittwood ianpittwood merged commit 4231a43 into dev Nov 8, 2023
87 of 89 checks passed
@ianpittwood ianpittwood deleted the rsw-2022.07.4 branch November 8, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfeinauer kfeinauer kfeinauer approved these changes

@cm421 cm421 Awaiting requested review from cm421 cm421 is a code owner

@melissa-barca melissa-barca Awaiting requested review from melissa-barca melissa-barca is a code owner

@colearendt colearendt Awaiting requested review from colearendt

@bschwedler bschwedler Awaiting requested review from bschwedler bschwedler is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianpittwood @kfeinauer