Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a few more unittests for rstudio-workbench #615

Merged
merged 5 commits into from
Nov 19, 2024

Conversation

jforest
Copy link
Contributor

@jforest jforest commented Nov 15, 2024

@zachhannum @nathanchilton I am including you both here as you were tapped by Maria and Jason respectively to be helping out with the helm chart unittesting/install testing work.

@jforest jforest marked this pull request as ready for review November 18, 2024 19:09
Copy link
Contributor

@GCRev GCRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm assuming that the Legacy Port values are not configurable and that they're always going to 9108.

@jforest
Copy link
Contributor Author

jforest commented Nov 18, 2024

LGTM. I'm assuming that the Legacy Port values are not configurable and that they're always going to 9108.

Exactly!

{{- if .Values.prometheus.enabled }}
- name: metrics
targetPort: metrics
{{- if .Values.prometheus.legacy }}
port: 9108
{{- else }}
port: {{ .Values.prometheus.port }}
{{- end }}

@jforest jforest merged commit 002bb89 into main Nov 19, 2024
7 checks passed
@jforest jforest deleted the add-more-unittests-workbench branch November 19, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants