fix: generate the Prisma client in the epic-stack example build - #118
Merged
Conversation
`pnpm build` in the epic-stack example failed on a fresh checkout because `@prisma/client` resolves `.prisma/client/default`, which only exists after `prisma generate`. Upstream Epic Stack runs that from its `setup` script, which nobody runs before building the example here. Generate the client as the first step of `build` so the example builds on its own. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
commit: |
Contributor
Benchmark results
|
Merging this PR will not alter performance
Comparing 
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm buildinexamples/epic-stackfailed on a fresh checkout withCan't resolve '.prisma/client/default'. The generated Prisma client only exists afterprisma generate, which upstream Epic Stack runs from itssetupscript. Run it as the first step ofbuildso the example builds on its own.Every other example (
client-only,cloudflare,custom-node-server,default-template,federation,prerender,react-router-8,rsc-mode,spa-mode) builds cleanly on currentmain; epic-stack was the only failure.Verification
Removed the generated client, then
pnpm buildinexamples/epic-stack:prisma generate,build:icons,build:remix(web and node), andbuild:serverall complete with exit code 0.🤖 Generated with Claude Code