Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add columns to FIXME and TODO tag checks #1181

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mhanberg
Copy link
Contributor

This allows text editors to correctly render the diagnostic

Before:
CleanShot 2025-02-28 at 14 16 15@2x

After:

CleanShot 2025-02-28 at 14 18 20@2x

This allows text editors to correctly render the diagnostic
@mhanberg
Copy link
Contributor Author

I'll look into those test failures

@rrrene
Copy link
Owner

rrrene commented Mar 5, 2025

This is looking good so far, thanks! 👍

We just have to make sure that it also works for module attributes, because the checks also catch the "tag" (TODO or FIXME) in those:

@doc """
Does something incredible. Returns `:ok` or `:error`.

TODO: add example
"""

Judging from the code, I get the impression that this is not considered yet?

rrrene added a commit that referenced this pull request Mar 5, 2025
@rrrene
Copy link
Owner

rrrene commented Mar 5, 2025

Hi, after writing the above, I realized that all I wrote was technically true, but of no concern to this PR 😞 🙏

I also realized that the column should have been there in the first place and fixed something in Credo.Check so that TagTODO and TagFIXME aren't the only checks benefiting from our exchange 👍

Could you check if your problem is now solved on master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants