Automatically set BUILDHOST and tag and add COOKIE tag #118
Conversation
dralley
force-pushed
the
compatibility
branch
3 times, most recently
from
24a3494 to
2655586
Compare
dralley
changed the title
dralley
force-pushed
the
compatibility
branch
2 times, most recently
from
8e5227b to
e713a98
Compare
| @@ -32,7 +34,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| ### Breaking Changes | |||
|
|
|||
| - Bump MSRV to 1.63.0 | |||
| - Bump MSRV to 1.64.0 | |||
There was a problem hiding this comment.
It'd be nice if we had an idea of what was pinning the MSRV high. It's better if the MSRV is lower, cause then implementors can have a lower MSRV and it's compatible with more versions of Rust.
There was a problem hiding this comment.
In this case gethostname wanted an MSRV bump. With an older version of gethosname it could possibly be pushed lower.
| pub fn get_build_cookie() -> String { | ||
| let build_time = SystemTime::now() | ||
| .duration_since(SystemTime::UNIX_EPOCH) | ||
| .unwrap() |
There was a problem hiding this comment.
Is this an infallible operation? Might be nice to be expect() if so.
There was a problem hiding this comment.
It ought to be effectively infalliable since it only returns Err when "earlier is later than self". So the system timestamp would have to be less than 0.
|
@cmeister2 Done |
There was a problem hiding this comment.
The changes in this PR are yepordizing binary reproducibility for sake of identical behavior to existing rpm tooling, which was never a goal for rpm-rs. I don't oppose the possibility of providing such data - adding timestamps and build host info should, at most, be an explicit OPT-IN as part of the builder, and not the default in any case.
Incremental improvement towards making an empty package built by rpm-r more similar to one created by rpmbuild
📜 Checklist
--all-featuresenabled