Repository navigation
fix(skills): restore Perfetto launcher and correct package identity - #439
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The mirrored changes are consistent and all 42 package identity regression checks pass.
Review effort: Balanced
Findings: None
What changed in this PR
Restores the Perfetto launcher and corrects Android package identity detection across all three skill mirrors.
Changes:
- Adds the pinned Perfetto v57.2 launcher and targeted ignore exceptions.
- Removes Maven group fallbacks from package detection.
- Adds regression coverage and refresh documentation.
| File | Description |
|---|---|
.gitignore |
Tracks only the vendored Perfetto launcher under ignored bin directories. |
skills/android-profiler/references/perfetto/bin/trace_processor |
Adds the Perfetto launcher. |
.agents/skills/android-profiler/references/perfetto/bin/trace_processor |
Mirrors the launcher. |
.claude/skills/android-profiler/references/perfetto/bin/trace_processor |
Mirrors the launcher. |
skills/play-policy-insights/scripts/orchestrator.py |
Removes Maven group identity fallbacks. |
.agents/skills/play-policy-insights/scripts/orchestrator.py |
Mirrors identity corrections. |
.claude/skills/play-policy-insights/scripts/orchestrator.py |
Mirrors identity corrections. |
scripts/test_android_skill_identity.py |
Tests 42 identity cases across all mirrors. |
docs/agents/workflow.md |
Documents the local patch and verification command. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix two regressions in the Android skills v1.0.13 refresh from #438. Include the upstream Perfetto launcher in all three mirrors and allow that specific file through the existing bin ignore rule, so the documented setup works in a fresh checkout.
Remove Maven group/groupId/GROUP fallbacks from Android package identity detection. These values can hide the real Manifest package, and project.property(...) was incorrectly treated as the literal package name. Document this local patch for future upstream refreshes.
Validation:
Skills/tooling only; no product code changes. Gradle/Xcode and product e2e are not applicable.