add inverse reverse param #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
requested changes
Jun 4, 2023
There was a problem hiding this comment.
Overall, I think this is an OK feature to have, as long as it is off by default.
I have a few requests:
- Please add something to the top-level README.md describing this parameter and what it does.
- Please retarget this PR to the
rollingbranch, which is where we do the main development. From there, we can consider backporting it to thehumblebranch.
Thank you!
|
Opened new PR #35 to rolling branch |
This was referenced Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
My story is: our team wanted to use xbox one joystick for controlling our robot with differential wheels in development. But in reverse the turning is inversed. I mean that for example if i want to go forward left then I have to push to joystick to forward and left, but if i want to go reverse left than i have to push the joystick to reverse rigth, so it is not intuitive.
I would like to propose a solution, already implemented and tested.
I have added a new param called "inverse_reverse" which make the joystick work more intuitively, so reverse left means reverse left on joystick as well pushing "M" on teleop twist keyboard.