Skip to content

Disable test failing in coverage jobs, see #812 #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Open

Disable test failing in coverage jobs, see #812 #853

wants to merge 1 commit into from

Conversation

Blast545
Copy link
Contributor

@Blast545 Blast545 commented Mar 10, 2025 •
edited
Loading

As the title says, see: #812 for details.

I will keep the WIP tag and the PR in draft mode until I validate that CI passes in coverage jobs with this PR. I'm not sure if gtest will get the DISABLED_test tag inside the TYPED_TEST macro.

@Blast545 Blast545 self-assigned this Mar 10, 2025
@Blast545
Copy link
Contributor Author

Blast545 commented Mar 10, 2025 •
edited
Loading

CI linux, coverage enabled, Build type: Debug. -- packages-up-to rosidl_typesupport_introspection_tests
Build Status

@Blast545 Blast545 marked this pull request as ready for review March 17, 2025 16:34
@Blast545 Blast545 changed the title (WIP) Disable test failing in coverage jobs, see #812 Disable test failing in coverage jobs, see #812 Mar 17, 2025
@Blast545
Copy link
Contributor Author

Blast545 commented Mar 17, 2025 •
edited
Loading

Re-running for the sake of checking the status of the job post migration, jic
Build Status

@Crola1702 Crola1702 mentioned this pull request Apr 22, 2025
Open
@claraberendsen claraberendsen self-requested a review April 25, 2025 18:40
claraberendsen
claraberendsen approved these changes Apr 25, 2025
View reviewed changes
Copy link

@claraberendsen claraberendsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: If we are leaving the comment to be able to track later DISABLED test let's use something a bit more descriptive of that than TODO maybe DISABLED or FIXME.

This looks good to me with another ci run since the last one was over a month ago (just to double check it still does what it did)

@Blast545
Copy link
Contributor Author

@claraberendsen For this one, IMO the DISABLED_ tag as part of the test name should do.

We also added it to the Buildfarm Triage spreadsheet. We are not sure if the dev time will invest time on this, but we'll track there and see how to move forward.

@Blast545
Copy link
Contributor Author

Re-running CI before merging:
Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claraberendsen claraberendsen claraberendsen approved these changes

Assignees

@Blast545 Blast545

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Blast545 @claraberendsen