Add name and data_type traits for actions #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements the `rosidl_generator_traits::name<>()` and `rosidl_generator_traits::data_type<>()` trait functions for generated actions, similarly to how it's done for messages and services. Unit tests are added to verify this behaviour, and also extend the prior tests to cover the data_type trait for all interface types. Signed-off-by: Nathan Wiebe Neufeldt <[email protected]>
|
Pulls: #848
|
|
@fujitatomoya Thanks for the review. Is there anything else needed for this to be merged? |
|
@nwn thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the
rosidl_generator_traits::name<>()androsidl_generator_traits::data_type<>()trait functions for generated actions, similarly to how it's done for messages and services.Unit tests are added to verify this behaviour, and the prior tests are extended to cover the
data_typetrait for all interface types.