Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record ROS2 Parameters within a ros2 bag #1462

Open
vinnnyr opened this issue Sep 8, 2023 · 1 comment
Open

Record ROS2 Parameters within a ros2 bag #1462

vinnnyr opened this issue Sep 8, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@vinnnyr
Copy link

vinnnyr commented Sep 8, 2023

Description

I would love it if we could store ROS2 Parameters that were present during runtime into a bag so that is archived in . Often I have trouble looking at bags of, let's say controller performance, but not having record of what controller parameters we used to achieve such performance.

Related Issues

I think in order to handle parameters changed DURING the bag recording, we need to also do #773 but it's not strictly blocking

Completion Criteria

  • All ROS2 parameters are saved at record time via optional CLI arg
  • Thes ROS2 parameters can be queryied / inspected after recording is done

Implementation Notes / Suggestions

** If you have ideas about how this feature might be accomplished, put them here. Note that this is just a suggestion to the implementer, so feel free to speculate. **
Maybe this is something to store in metadata.yaml? maybe it can take advantage of the key value pair in the bag?

Testing Notes / Suggestions

** All features in this project need tests. Please give some input on cases that will need to be tested - and how the testing might be implemented. **

@vinnnyr vinnnyr added the enhancement New feature or request label Sep 8, 2023
@MichaelOrlov
Copy link
Contributor

@vinnnyr The key problem here is how to get those parameters from the remote nodes.
Any ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants