Try to use the git global user.name for maintainer-name #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l user.name (likely a full name) before trying to use the OS login name Signed-off-by: Larry Gezelius <[email protected]>
…s; remove "global" from comment; remove spaces from generated email address Signed-off-by: Larry Gezelius <[email protected]>
lgezelius
force-pushed
the
git-username-for-maintainer-name
branch
from
2bcb4ed to
fe2d37c
Compare
Signed-off-by: Larry Gezelius <[email protected]>
Signed-off-by: Larry Gezelius <[email protected]>
lgezelius
force-pushed
the
git-username-for-maintainer-name
branch
from
88d3054 to
eabb50c
Compare
|
Pulls: #968
|
christophebedard
approved these changes
Feb 9, 2025
christophebedard
requested changes
Feb 9, 2025
There was a problem hiding this comment.
The tests fail on Windows: https://ci.ros2.org/job/ci_linux-rhel/2002/consoleFull#console-section-425. Turns out | was only added in Python 3.10: https://peps.python.org/pep-0604/. And Windows uses Python 3.8: https://www.ros.org/reps/rep-2000.html#jazzy-jalisco-may-2024-may-2029.
Signed-off-by: Larry Gezelius <[email protected]>
|
Thanks for the fix. New CI:
|
christophebedard
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add code for "ros2 pkg create" so that the first default for the maintainer-name is the git user.name, which is likely a full name, instead of first using an OS login name. This creates more consistency, because the maintainer-email already defaults to the git user.email.