Skip to content

Update CMakeLists.txt #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 20, 2025
Merged

Update CMakeLists.txt #176

merged 2 commits into from
May 20, 2025

Conversation

mosfet80
Copy link
Contributor

Description

Fixes # (issue)
cmake 3.5 is deprecated. switch to cmake 3.20 humble requirement

Is this user-facing behavior change?

Did you use Generative AI?

Additional Information

mosfet80 added 2 commits May 19, 2025 23:33
@mosfet80
Update CMakeLists.txt
2f02578 
cmake 3.5 is deprecated.

Signed-off-by: mosfet80 <[email protected]>
@mosfet80
Update CMakeLists.txt
324f4e7 
Signed-off-by: mosfet80 <[email protected]>
christophebedard
christophebedard approved these changes May 19, 2025
View reviewed changes
Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@christophebedard
Copy link
Member

christophebedard commented May 19, 2025 •
edited
Loading

Pulls: #176
Gist: https://gist.githubusercontent.com/christophebedard/08860ab9e8ef5560f108424237d96f2f/raw/197edef4e58ac58f0e8ec05a5b80edc3d3f96ea7/ros2.repos
BUILD args: --packages-above-and-dependencies tracetools test_tracetools
TEST args: --packages-above tracetools test_tracetools
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16044

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 148d46f into ros2:rolling May 20, 2025
6 of 9 checks passed
@ahcorde
Copy link
Contributor

ahcorde commented May 20, 2025

https://github.com/Mergifyio backport kilted

@mergify Mergify
Copy link

mergify bot commented May 20, 2025 •
edited
Loading

backport kilted

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 20, 2025
@mosfet80 @mergify
Update CMakeLists.txt (#176)
2fbb157 
Signed-off-by: mosfet80 <[email protected]>
(cherry picked from commit 148d46f)
@mergify mergify bot mentioned this pull request May 20, 2025
Merged
ahcorde pushed a commit that referenced this pull request May 26, 2025
@mergify @mosfet80
Update CMakeLists.txt (#176) (#177)
3608b2c 
(cherry picked from commit 148d46f)

Signed-off-by: mosfet80 <[email protected]>
Co-authored-by: mosfet80 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@christophebedard christophebedard christophebedard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mosfet80 @christophebedard @ahcorde