Update dependecies #5595
Update dependecies #5595
Conversation
Nils-ChristianIseke
force-pushed
the
UpdateDependecies
branch
from
70818c3 to
098a31a
Compare
| RUN . /opt/ros2doc/bin/activate && pip3 install -r requirements.txt -c constraints.txt | ||
|
|
||
| RUN echo "source /opt/ros2doc/bin/activate" >> /home/$user/.bashrc | ||
| USER $user |
There was a problem hiding this comment.
Is there any reason that we use a non root user in the container? In the current setup we would need sudo rights for installing pip and apt requirements.
| MarkupSafe==2.0.1 | ||
| packaging==21.3 | ||
| pbr==5.8.0 | ||
| alabaster==0.7.16 |
There was a problem hiding this comment.
Fixed dependencies to latest available versions because they are working with all tools. Or is there a specific reason to stick to the dep availible via apt?
|
@christophebedard some open questions from my side. Happy if you could have a look? |
|
I will take a look once I'm back from vacation on Tuesday-ish! |
| FROM ubuntu:jammy | ||
| FROM ubuntu:noble |
There was a problem hiding this comment.
Any plans using a deployed Docker image instead of the Dockerfile? I can create an issue for this if you think this is reasonable to do.
| @@ -20,7 +20,8 @@ RUN apt-get update && \ | |||
| graphviz \ | |||
| locales \ | |||
| make \ | |||
| python3-pip && \ | |||
| python3-pip \ | |||
There was a problem hiding this comment.
Just to support uv , we could consider uv instead of pip (much faster, venv support, better dep. management). Can create an issue for this if wanted.
Use noble for CI.