-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add warning that actions require ament_cmake, not ament_python #4986 #5201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vimal0athithan
wants to merge
13
commits into
ros2:rolling
Choose a base branch
from
vimal0athithan:rolling
base: rolling
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
fcb450c
Add warning that actions require ament_cmake, not ament_python #4986
vimal0athithan 821f030
Applied reviewer suggestions: Moved lines 45-46 outside warning block…
vimal0athithan ccdb40e
Fix linting and test failures based on check logs
vimal0athithan be69146
Update source/Tutorials/Intermediate/Creating-an-Action.rst
kscottz bc04c8f
Update source/Tutorials/Intermediate/Creating-an-Action.rst
kscottz 87be1e0
Update source/Tutorials/Intermediate/Creating-an-Action.rst
kscottz 95542c1
Update source/Tutorials/Intermediate/Creating-an-Action.rst
kscottz 054e030
Fix trailing whitespace on line 44 and add newline at end of file
vimal0athithan 55215ad
Fix trailing whitespace on line 44 and add newline at end of file
vimal0athithan f362035
Update source/Tutorials/Intermediate/Creating-an-Action.rst
kscottz 8b2178c
Update source/Tutorials/Intermediate/Creating-an-Action.rst
kscottz 2f1b4e6
Update source/Tutorials/Intermediate/Creating-an-Action.rst
kscottz ddd6e82
Update source/Tutorials/Intermediate/Creating-an-Action.rst
kscottz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -41,6 +41,14 @@ Tasks | |||||
1 Creating an interface package | ||||||
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||||||
|
||||||
Actions can only be created in a package using `ament_cmake`. | ||||||
They are not supported in Python packages using `ament_python`. | ||||||
This restriction also applies to messages and services, so | ||||||
kscottz marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
|
||||||
.. note:: | ||||||
It is recommended to define action interfaces in this tutorial. | ||||||
kscottz marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
This improves modularity and makes it easier to reuse them across multiple projects. | ||||||
|
||||||
.. tabs:: | ||||||
|
||||||
.. group-tab:: Linux | ||||||
|
@@ -206,9 +214,12 @@ and how to verify a successful build. | |||||
Next steps | ||||||
---------- | ||||||
|
||||||
Next, let's utilize your newly defined action interface by creating an action service and client (in :doc:`Python <Writing-an-Action-Server-Client/Py>` or :doc:`C++ <Writing-an-Action-Server-Client/Cpp>`). | ||||||
Next, let's utilize your newly defined action interface by creating an action server | ||||||
and client (in :doc:`Python <Writing-an-Action-Server-Client/Py>` or :doc:`C++ <Writing-an-Action-Server-Client/Cpp>`). | ||||||
kscottz marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
|
||||||
Related content | ||||||
--------------- | ||||||
|
||||||
For more detailed information about ROS actions, please refer to the `design article <http://design.ros2.org/articles/actions.html>`__. | ||||||
For more detailed information about ROS actions, please refer to the `design article <https://design.ros2.org/articles/actions.html>`__. | ||||||
|
||||||
[blank line] | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what is this?
Suggested change
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.