fix group tag indent for ROSCon 2023 and 2024 contents. #5016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomoya Fujita <[email protected]>
fujitatomoya
requested review from
kscottz
and removed request for
clalancette and
audrow
fujitatomoya
added
the
backport-all
fujitatomoya
commented
Feb 13, 2025
| .. group-tab:: 2024 | ||
| .. group-tab:: 2024 |
There was a problem hiding this comment.
because of this indent miss, https://docs.ros.org/en/rolling/The-ROS2-Project/ROSCon-Content.html cannot show 2023 and 2024 contents properly.
|
@kscottz can you take a look at this? i think this is just easy mistake. |
|
HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/13316606264/artifacts/2588645314. To view the resulting site:
|
christophebedard
approved these changes
Feb 13, 2025
ahcorde
approved these changes
Feb 13, 2025
kscottz
approved these changes
Feb 13, 2025
|
I hate to say it, but one of these days we're going to need to add some Selenium tests to the docs. I wonder if there is a way to add a basic link validator to catch this kind of stuff. |
mergify bot
pushed a commit
that referenced
this pull request
Feb 14, 2025
Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 489bb78)
mergify bot
pushed a commit
that referenced
this pull request
Feb 14, 2025
Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 489bb78)
This was referenced Feb 14, 2025
fujitatomoya
added a commit
that referenced
this pull request
Feb 14, 2025
Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 489bb78) Co-authored-by: Tomoya Fujita <[email protected]>
fujitatomoya
added a commit
that referenced
this pull request
Feb 14, 2025
Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 489bb78) Co-authored-by: Tomoya Fujita <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.