Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use ubuntu:jammy for container, otherwise doc8 fails to start. #5007

Merged
merged 1 commit into from
Feb 10, 2025
Merged

use ubuntu:jammy for container, otherwise doc8 fails to start. #5007

merged 1 commit into from
Feb 10, 2025

Conversation

fujitatomoya
Copy link
Collaborator

closes #5006

@fujitatomoya fujitatomoya added the backport-all backport at reviewers discretion; from rolling to all versions label Feb 10, 2025
@fujitatomoya fujitatomoya self-assigned this Feb 10, 2025
@fujitatomoya fujitatomoya changed the title use ubuntu:jammy for container, otherwise doc8 failes to start. use ubuntu:jammy for container, otherwise doc8 fails to start. Feb 10, 2025
@fujitatomoya
Copy link
Collaborator Author

@christophebedard can you review this? i confirmed that all Makefile targets work with devcontainer.

@github-actions GitHub Actions
Copy link

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/13233301649/artifacts/2562228718.

To view the resulting site:

  1. Click on the above link to download the artifacts archive
  2. Extract it
  3. Open html-artifacts-5007/index.html in your favorite browser

@fujitatomoya fujitatomoya merged commit 67f669d into rolling Feb 10, 2025
5 checks passed
@fujitatomoya fujitatomoya deleted the fujitatomoya/fix-devcontainer branch February 10, 2025 17:33
mergify bot pushed a commit that referenced this pull request Feb 10, 2025
@fujitatomoya @mergify
use ubuntu:jammy for container, otherwise doc8 failes to start. (#5007)
4e98f62 
Signed-off-by: Tomoya.Fujita <[email protected]>
(cherry picked from commit 67f669d)
mergify bot pushed a commit that referenced this pull request Feb 10, 2025
@fujitatomoya @mergify
use ubuntu:jammy for container, otherwise doc8 failes to start. (#5007)
f1914ca 
Signed-off-by: Tomoya.Fujita <[email protected]>
(cherry picked from commit 67f669d)
This was referenced Feb 10, 2025
Merged
Merged
fujitatomoya added a commit that referenced this pull request Feb 10, 2025
@mergify @fujitatomoya
use ubuntu:jammy for container, otherwise doc8 failes to start. (#5007)…
fa1dcaa 
… (#5009)

Signed-off-by: Tomoya.Fujita <[email protected]>
(cherry picked from commit 67f669d)

Co-authored-by: Tomoya Fujita <[email protected]>
fujitatomoya added a commit that referenced this pull request Feb 10, 2025
@mergify @fujitatomoya
use ubuntu:jammy for container, otherwise doc8 failes to start. (#5007)…
6e7fe3d 
… (#5008)

Signed-off-by: Tomoya.Fujita <[email protected]>
(cherry picked from commit 67f669d)

Co-authored-by: Tomoya Fujita <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophebedard christophebedard christophebedard approved these changes

@clalancette clalancette Awaiting requested review from clalancette clalancette is a code owner

@audrow audrow Awaiting requested review from audrow audrow is a code owner

Assignees

@fujitatomoya fujitatomoya

Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make test fails to start with using devcontainer.
2 participants
@fujitatomoya @christophebedard