Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove underscored objects from rosbag_py tutorial (backport #4976) #4979

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 29, 2025

Some objects that are available directly from the rosbag2_py root module are imported from the underscored modules they live in. This change removes the underscore modules and uses the objects from the root module.


This is an automatic backport of pull request #4976 done by Mergify.

remove underscore methods that are imported into rosbag2_py in __init__.py

Signed-off-by: Joe Rickwalder <[email protected]>
(cherry picked from commit 9f4a25f)

# Conflicts:
#	source/Tutorials/Advanced/Recording-A-Bag-From-Your-Own-Node-Py.rst
@mergify mergify bot requested a review from clalancette as a code owner January 29, 2025 23:30
@mergify mergify bot added the conflicts label Jan 29, 2025
@mergify mergify bot requested a review from audrow as a code owner January 29, 2025 23:30
Copy link
Contributor Author

mergify bot commented Jan 29, 2025

Cherry-pick of 9f4a25f has failed:

On branch mergify/bp/jazzy/pr-4976
Your branch is up to date with 'origin/jazzy'.

You are currently cherry-picking commit 9f4a25f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   source/Tutorials/Advanced/Recording-A-Bag-From-Your-Own-Node-Py.rst

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Signed-off-by: Tomoya Fujita <[email protected]>
@fujitatomoya fujitatomoya force-pushed the mergify/bp/jazzy/pr-4976 branch from 4b871e7 to c8e66ee Compare January 29, 2025 23:50
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christophebedard can you merge this?

Copy link

github-actions bot commented Jan 29, 2025

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/13042663767/artifacts/2507706456.

To view the resulting site:

  1. Click on the above link to download the artifacts archive
  2. Extract it
  3. Open html-artifacts-4979/index.html in your favorite browser

@ahcorde ahcorde merged commit bb6da88 into jazzy Jan 30, 2025
4 checks passed
@ahcorde ahcorde deleted the mergify/bp/jazzy/pr-4976 branch January 30, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants