Remove underscored objects from rosbag_py tutorial (backport #4976) #4978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
remove underscore methods that are imported into rosbag2_py in __init__.py Signed-off-by: Joe Rickwalder <[email protected]> (cherry picked from commit 9f4a25f) # Conflicts: # source/Tutorials/Advanced/Recording-A-Bag-From-Your-Own-Node-Py.rst
|
Cherry-pick of 9f4a25f has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Signed-off-by: Tomoya Fujita <[email protected]>
fujitatomoya
approved these changes
Jan 29, 2025
| @@ -87,10 +87,10 @@ Inside the ``ros2_ws/src/bag_reader_node_py/bag_reader_node_py`` directory, crea | |||
| def __init__(self): | |||
| super().__init__('simple_bag_reader') | |||
| self.reader = rosbag2_py.SequentialReader() | |||
| storage_options = rosbag2_py._storage.StorageOptions( | |||
| storage_options = rosbag2_py.StorageOptions( | |||
There was a problem hiding this comment.
this file only needs to be changed for rolling, but all changes are aligned with original fix to remove internal module for examples.
|
HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/13042702526/artifacts/2507717862. To view the resulting site:
|
ahcorde
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some objects that are available directly from the rosbag2_py root module are imported from the underscored modules they live in. This change removes the underscore modules and uses the objects from the root module.
This is an automatic backport of pull request #4976 done by Mergify.