Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add example how to use wildcards in parameter yaml file. #4950

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

fujitatomoya
Copy link
Collaborator

closes #3004

@fujitatomoya fujitatomoya force-pushed the fujitatomoya/add-parameter-wildcards-example branch from 4fa78e7 to d959481 Compare January 20, 2025 20:30
@fujitatomoya
Copy link
Collaborator Author

@christophebedard @ahcorde either of you, can you take a look?

Copy link

github-actions bot commented Jan 20, 2025

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/12895110072/artifacts/2463999679.

To view the resulting site:

  1. Click on the above link to download the artifacts archive
  2. Extract it
  3. Open html-artifacts-4950/index.html in your favorite browser

source/How-To-Guides/Node-arguments.rst Outdated Show resolved Hide resolved
source/How-To-Guides/Node-arguments.rst Outdated Show resolved Hide resolved
Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Can this be backported to all active distros?

@fujitatomoya
Copy link
Collaborator Author

@christophebedard thank for the review, and yes we can do that.

@fujitatomoya fujitatomoya merged commit c717d69 into rolling Jan 21, 2025
4 checks passed
@fujitatomoya fujitatomoya deleted the fujitatomoya/add-parameter-wildcards-example branch January 21, 2025 23:51
@fujitatomoya fujitatomoya added the backport-all backport at reviewers discretion; from rolling to all versions label Jan 21, 2025
mergify bot pushed a commit that referenced this pull request Jan 21, 2025
* add example how to use wildcards in parameter yaml file.

Signed-off-by: Tomoya.Fujita <[email protected]>

* adjust explanation a bit and typo fixes.

Signed-off-by: Tomoya.Fujita <[email protected]>

---------

Signed-off-by: Tomoya.Fujita <[email protected]>
Signed-off-by: Tomoya.Fujita <[email protected]>
(cherry picked from commit c717d69)
mergify bot pushed a commit that referenced this pull request Jan 21, 2025
* add example how to use wildcards in parameter yaml file.

Signed-off-by: Tomoya.Fujita <[email protected]>

* adjust explanation a bit and typo fixes.

Signed-off-by: Tomoya.Fujita <[email protected]>

---------

Signed-off-by: Tomoya.Fujita <[email protected]>
Signed-off-by: Tomoya.Fujita <[email protected]>
(cherry picked from commit c717d69)

# Conflicts:
#	source/How-To-Guides/Node-arguments.rst
fujitatomoya added a commit that referenced this pull request Jan 21, 2025
* add example how to use wildcards in parameter yaml file.

Signed-off-by: Tomoya.Fujita <[email protected]>

* adjust explanation a bit and typo fixes.

Signed-off-by: Tomoya.Fujita <[email protected]>

---------

Signed-off-by: Tomoya.Fujita <[email protected]>
Signed-off-by: Tomoya.Fujita <[email protected]>
(cherry picked from commit c717d69)

Co-authored-by: Tomoya Fujita <[email protected]>
fujitatomoya added a commit that referenced this pull request Jan 22, 2025
) (#4956)

* add example how to use wildcards in parameter yaml file. (#4950)

* add example how to use wildcards in parameter yaml file.

Signed-off-by: Tomoya.Fujita <[email protected]>

* adjust explanation a bit and typo fixes.

Signed-off-by: Tomoya.Fujita <[email protected]>

---------

Signed-off-by: Tomoya.Fujita <[email protected]>
Signed-off-by: Tomoya.Fujita <[email protected]>
(cherry picked from commit c717d69)

# Conflicts:
#	source/How-To-Guides/Node-arguments.rst

* resolve conflict.

Signed-off-by: Tomoya.Fujita <[email protected]>

---------

Signed-off-by: Tomoya.Fujita <[email protected]>
Co-authored-by: Tomoya Fujita <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add documentation about parameter wildcard matching
2 participants