Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "ros2 action type" from Humble/Iron. #4291

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

clalancette
Copy link
Contributor

It was recently added to Rolling, but Humble and Iron don't have it. Remove the tutorial portion from humble and iron.

This will fix #4289 . @fujitatomoya FYI

It was recently added to Rolling, but Humble and Iron
don't have it.  Remove the tutorial portion from humble
and iron.

Signed-off-by: Chris Lalancette <[email protected]>
@clalancette clalancette requested a review from audrow as a code owner April 16, 2024 17:47
@clalancette clalancette merged commit 5e9610c into humble Apr 16, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the clalancette/remove-action-type branch April 16, 2024 17:59
@clalancette
Copy link
Contributor Author

@Mergifyio backport iron

Copy link
Contributor

mergify bot commented Apr 16, 2024

backport iron

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 16, 2024
It was recently added to Rolling, but Humble and Iron
don't have it.  Remove the tutorial portion from humble
and iron.

Signed-off-by: Chris Lalancette <[email protected]>
(cherry picked from commit 5e9610c)
@fujitatomoya
Copy link
Collaborator

@clalancette Ah, sorry about that. I did add 2 fixes, one in release note and the other is in tutorial. so backporting it breaks the tutorial for previous distros. i will keep that in my mind for the future doc update. thanks for taking care of this.

clalancette added a commit that referenced this pull request Apr 16, 2024
It was recently added to Rolling, but Humble and Iron
don't have it.  Remove the tutorial portion from humble
and iron.

Signed-off-by: Chris Lalancette <[email protected]>
(cherry picked from commit 5e9610c)

Co-authored-by: Chris Lalancette <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants