Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rolling rosdistro #4244

Merged
merged 10 commits into from
Apr 9, 2024
Merged

Conversation

SteveMacenski
Copy link
Contributor

Adds a how-to guide for setting the rosdistro index in the context of rolling breakages on OS transitions

Signed-off-by: Steve Macenski <[email protected]>
@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/psa-rolling-ci-or-docker-build-fix-from-rosdep-errors-in-24-04-transition/36902/1

Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SteveMacenski quick question. is this just a temporary documentation to support the transition period for rolling from 22.04 to 24.04? it looks really specific for this transition period. i was thinking this could be more useful and general, but relevant from specific transition period? (i can feel your pain here... 😅 )

@SteveMacenski
Copy link
Contributor Author

SteveMacenski commented Mar 29, 2024

is this just a temporary documentation to support the transition period for rolling from 22.04 to 24.04?

It also covers 24.04 to 26.04, and so on. But yes, this is targeting for handling during transition periods, but as I mention a couple of times in the document, could be used for your own specific rosdistro needs (this is just the motivating example I'm How-To-ing on).

I prefer non-abstract examples so someone can understand in a particular context what to do. I find it easier to read and mentally insert my own problem set rather than just saying OS-X to OS-Z and keeping things so general that it makes the language hard to follow. Given that this is in the How-To section of the website, that feels like the appropriate diction anyway

SteveMacenski and others added 2 commits March 29, 2024 10:21
Co-authored-by: Tomoya Fujita <[email protected]>
Signed-off-by: Steve Macenski <[email protected]>
Co-authored-by: Tomoya Fujita <[email protected]>
Signed-off-by: Steve Macenski <[email protected]>
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In short, this is great documentation. I think having a motivating example here works for me.

I've left a few minor typos inline and such, but otherwise I think this is good.

@clalancette clalancette added the backport-all backport at reviewers discretion; from rolling to all versions label Apr 9, 2024
SteveMacenski and others added 5 commits April 9, 2024 09:18
Co-authored-by: Chris Lalancette <[email protected]>
Signed-off-by: Steve Macenski <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]>
Signed-off-by: Steve Macenski <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]>
Signed-off-by: Steve Macenski <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]>
Signed-off-by: Steve Macenski <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]>
Signed-off-by: Steve Macenski <[email protected]>
@clalancette clalancette merged commit bf7e9c9 into ros2:rolling Apr 9, 2024
4 checks passed
mergify bot pushed a commit that referenced this pull request Apr 9, 2024
* Adding how-to build on custom rosdistro files

Signed-off-by: Steve Macenski <[email protected]>
Co-authored-by: Tomoya Fujita <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]>
(cherry picked from commit bf7e9c9)
mergify bot pushed a commit that referenced this pull request Apr 9, 2024
* Adding how-to build on custom rosdistro files

Signed-off-by: Steve Macenski <[email protected]>
Co-authored-by: Tomoya Fujita <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]>
(cherry picked from commit bf7e9c9)
@SteveMacenski SteveMacenski deleted the rolling_rosdistro branch April 9, 2024 17:32
clalancette pushed a commit that referenced this pull request Apr 9, 2024
* Adding how-to build on custom rosdistro files

Signed-off-by: Steve Macenski <[email protected]>
Co-authored-by: Tomoya Fujita <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]>
(cherry picked from commit bf7e9c9)

Co-authored-by: Steve Macenski <[email protected]>
clalancette pushed a commit that referenced this pull request Apr 9, 2024
* Adding how-to build on custom rosdistro files

Signed-off-by: Steve Macenski <[email protected]>
Co-authored-by: Tomoya Fujita <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]>
(cherry picked from commit bf7e9c9)

Co-authored-by: Steve Macenski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants