Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update link to launch documentation #4225

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

ottojo
Copy link
Contributor

@ottojo ottojo commented Mar 13, 2024

Use link to hosted documentation instead of sources

Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think that is okay to use https://docs.ros.org/en/{DISTRO} and some other docs already use that. out of curiosity, https://docs.ros.org/en/{DISTRO} hosts the up-to-date information from the source daily?

@clalancette
Copy link
Contributor

i think that is okay to use https://docs.ros.org/en/{DISTRO} and some other docs already use that. out of curiosity, https://docs.ros.org/en/{DISTRO} hosts the up-to-date information from the source daily?

It's not daily, but it happens "sometimes". I'm honestly not sure what the schedule is at the moment, but there are some mechanisms to make sure it does eventually rebuild.

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. This will only work for rolling and iron, so I'll just backport this to both of those right now.

@clalancette clalancette added the backport-iron backport at reviewers discretion; from rolling to iron label Mar 13, 2024
@clalancette clalancette merged commit b136277 into ros2:rolling Mar 13, 2024
4 checks passed
@clalancette
Copy link
Contributor

@Mergifyio backport iron

Copy link
Contributor

mergify bot commented Mar 13, 2024

backport iron

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 13, 2024
clalancette pushed a commit that referenced this pull request Mar 13, 2024
(cherry picked from commit b136277)

Co-authored-by: Jonas Otto <[email protected]>
@ottojo ottojo deleted the launch_docs_link_fix branch March 13, 2024 18:59
@ottojo
Copy link
Contributor Author

ottojo commented Mar 13, 2024

i think that is okay to use https://docs.ros.org/en/{DISTRO} and some other docs already use that. out of curiosity, https://docs.ros.org/en/{DISTRO} hosts the up-to-date information from the source daily?

It's not daily, but it happens "sometimes". I'm honestly not sure what the schedule is at the moment, but there are some mechanisms to make sure it does eventually rebuild.

If you find out more information about the schedule/triggers, please do let me know so i can add that information to #4196 !

@clalancette
Copy link
Contributor

If you find out more information about the schedule/triggers, please do let me know so i can add that information to #4196 !

So it looks like the Jenkins job is configured to Poll SCM at this interval: H 3 H/3 * * So I guess every 3rd day it gets polled. That said, I'm not entirely sure I want to document that exact number, as it could change based on external factors (like cost).

@ottojo
Copy link
Contributor Author

ottojo commented Mar 13, 2024

If you find out more information about the schedule/triggers, please do let me know so i can add that information to #4196 !

So it looks like the Jenkins job is configured to Poll SCM at this interval: H 3 H/3 * * So I guess every 3rd day it gets polled. That said, I'm not entirely sure I want to document that exact number, as it could change based on external factors (like cost).

alright, thats understandable. in that case i will leave it at "it is built periodically" 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-iron backport at reviewers discretion; from rolling to iron
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants